8000 Comparing golang:master...fortio:release · golang/term · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/term
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: fortio/term
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: release
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 10 commits
  • 7 files changed
  • 3 contributors

Commits on Aug 8, 2024

  1. Expose History() AddToHistory() and NewHistory() so users of the libr… 

    …ary can save and restore the history
    @ldemailly
    ldemailly committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    1ca6c26 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1 from fortio/expose_history 

    Expose History() AddToHistory() and NewHistory() so users of the library can save and restore the history
    @ldemailly
    ldemailly authored Aug 8, 2024
    Configuration menu
    Copy the full SHA
    760ea90 View commit details
    Browse the repository at this point in the history

  3. prep for release under fortio.org/term (#2)

    @ldemailly
    ldemailly authored Aug 8, 2024
    Configuration menu
    Copy the full SHA
    113a4d5 View commit details
    Browse the repository at this point in the history

  4. Don't add adjacent duplicates to history (#3)

    @ldemailly
    ldemailly authored Aug 8, 2024
    Configuration menu
    Copy the full SHA
    7796a13 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. Add AutoHistory(false) option (default remains true) to not automatic… 

    …ally add to the History (#4)

* Add AutoHistory(false) option (default remains true) to not automatically add to the History and let the caller of ReadLine() decide, for instance to only add validated commands
    @ldemailly
    ldemailly authored Aug 9, 2024
    Configuration menu
    Copy the full SHA
    e4cae6f View commit details
    Browse the repository at this point in the history

  2. Add ReplaceLatest() to mutate top of history. Add comments. Expose De… 

    …faultHistoryEntries as const (#5)

* Add ReplaceLatest() to mutate top of history. Add comments. Expose DefaultHistoryEntries as const

* Correct godoc for ReplaceLatest
    @ldemailly
    ldemailly authored Aug 9, 2024
    Configuration menu
    Copy the full SHA
    ed77b0f View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2024

  1. Fix windows not receiving arrow keys (golang/go#68830) (#6)

    @ldemailly
    ldemailly authored Aug 10, 2024
    Configuration menu
    Copy the full SHA
    07a4a9e View commit details
    Browse the repository at this point in the history

  2. Change history default to 99 from 100 so history printed with %02d lo… 

    …oks good (#7)
    @ldemailly
    ldemailly authored Aug 10, 2024
    Configuration menu
    Copy the full SHA
    6308a8b View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2025

  1. Rebase from x/term master (includes my windows fix) (#9) 

    * x/term: set missing VIRTUAL_TERMINAL_INPUT flag on Windows

With this change the arrow keys work with Windows 11 Terminal

After verifying https://github.com/containerd/console did work fine, unlike x/term, it's because they have:
https://github.com/containerd/console/blob/v1.0.4/console_windows.go#L194
using the same flag fixed x/term for my program

Small e2e test reproducing the issue and showing it being fixed can be ran using

go run fortio.org/terminal/example@v0.6.0  # has the fix (or @latest)

go run fortio.org/terminal/example@v0.5.1  -history .history # does not have working arrow keys/this fix

Fixes golang/go#68830

Change-Id: If20addd054c76b889a52f933695467812be72306
GitHub-Last-Rev: 68e3ca0
GitHub-Pull-Request: #17
Reviewed-on: https://go-review.googlesource.com/c/term/+/603960
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Commit-Queue: Ian Lance Taylor <iant@google.com>
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>

* go.mod: update golang.org/x dependencies

Update golang.org/x dependencies to their latest tagged versions.

Change-Id: Ia875ad082f993ce02f2cf97d6d3b318091360433
Reviewed-on: https://go-review.googlesource.com/c/term/+/610637
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
Auto-Submit: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>

* go.mod: update golang.org/x dependencies

Update golang.org/x dependencies to their latest tagged versions.

Change-Id: I1fc21941bdc8066f3a8d24afdf16e6e10bceaf55
Reviewed-on: https://go-review.googlesource.com/c/term/+/617955
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: David Chase <drchase@google.com>
Auto-Submit: Gopher Robot <gobot@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>

* README: don't recommend go get

These days people will just import the packages and the go tool will
do the right thing. We don't need to explain it.

Add a pointer to the git repo, though.

For golang/go#62645

Change-Id: I641439c4fa02391fb77b05d639d6815094724a3a
Reviewed-on: https://go-review.googlesource.com/c/term/+/624216
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Commit-Queue: Ian Lance Taylor <iant@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>

* go.mod: update golang.org/x dependencies

Update golang.org/x dependencies to their latest tagged versions.

Change-Id: I4ba440821ddd8ce48c2658e67836ff4fbcdd258d
Reviewed-on: https://go-review.googlesource.com/c/term/+/626355
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Gopher Robot <gobot@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: David Chase <drchase@google.com>

* go.mod: update golang.org/x dependencies

Update golang.org/x dependencies to their latest tagged versions.

Change-Id: I8348c05748f22f6b6701a197b29e8b6dba837d0d
Reviewed-on: https://go-review.googlesource.com/c/term/+/633476
Auto-Submit: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: David Chase <drchase@google.com>

* go.mod: update golang.org/x dependencies

Update golang.org/x dependencies to their latest tagged versions.

Change-Id: Ib4be7af15f194517725e80dde8b52ce59dce04c9
Reviewed-on: https://go-review.googlesource.com/c/term/+/640357
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Gopher Robot <gobot@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Revie
9E36
wed-by: David Chase <drchase@google.com>

* Expose History() AddToHistory() and NewHistory() so users of the library can save and restore the history

* prep for release under fortio.org/term (#2)

* Don't add adjacent duplicates to history (#3)

* Add AutoHistory(false) option (default remains true) to not automatically add to the History (#4)

* Add AutoHistory(false) option (default remains true) to not automatically add to the History and let the caller of ReadLine() decide, for instance to only add validated commands

* Add ReplaceLatest() to mutate top of history. Add comments. Expose DefaultHistoryEntries as const (#5)

* Add ReplaceLatest() to mutate top of history. Add comments. Expose DefaultHistoryEntries as const

* Correct godoc for ReplaceLatest

* Change history default to 99 from 100 so history printed with %02d looks good (#7)

---------

Co-authored-by: Gopher Robot <gobot@golang.org>
Co-authored-by: Ian Lance Taylor <iant@golang.org>
    @ldemailly @gopherbot @ianlancetaylor
    3 people authored Jan 26, 2025
    Configuration menu
    Copy the full SHA
    352d5f5 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2025

  1. Indicate this is not needed anymore (#10)

    @ldemailly
    ldemailly authored Apr 21, 2025
    Configuration menu
    Copy the full SHA
    271806d View commit details
    Browse the repository at this point in the history
Loading
0