8000 Fix #315 causes exception when name not provided · Issue #320 · frappe/charts · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Fix #315 causes exception when name not provided #320
New issue
New issue
Closed
Closed
Fix #315 causes exception when name not provided#320
@jmrossy

Description

@jmrossy
jmrossy
opened on Dec 19, 2020

Expected Behaviour

No exception when name is left null/undefined

Actual Behaviour

Exception is thrown.
The issue is with this line which was modified in the last release:
https://github.com/frappe/charts/pull/315/files#diff-5fae7e3027fe415c8929935437f5b31e266fddc2b776cd2df8210f4f51f3512fR113

Steps to Reproduce:

  • Create a chart with a dataset that has no name
  • Exception is thrown due to attempt to call replace on undefined

Frappé Charts version: v1.5.5

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions
      0