1.1.8 #291
Merged
1.1.8 #291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was no documentation at all. It's important to document that this should also save parameter values.
Document the relationship between the params and state extensions
Fix typos in API
Bremmers
reviewed
Mar 6, 2023
Bremmers
reviewed
Mar 7, 2023
Bremmers
reviewed
Mar 7, 2023
robbert-vdh
suggested changes
Mar 7, 2023
robbert-vdh
reviewed
Mar 7, 2023
Trinitou
suggested changes
Mar 8, 2023
There was a problem hiding this comment.
The second question would be concerning the clap_preset_discovery_metadata_receiver::add_plugin_id method:
Should it be possible to add plugin id's that aren't provided by the .clap file itself? I mean, in theory now one could write a clap that only contains the preset discovery factory and provides presets for other clap plugins. Or should that be forbidden?
Bremmers
approved these changes
Mar 9, 2023
robbert-vdh
suggested changes
Mar 9, 2023
Co-authored-by: Robbert van der Helm <mail@robbertvanderhelm.nl>
Trinitou
reviewed
Mar 9, 2023
Co-authored-by: Trinitou <106991375+Trinitou@users.noreply.github.com>
Add clarification note about threading while GUI is alive
Trinitou
reviewed
Mar 11, 2023
move stream documentation to stream.h
robbert-vdh
approved these changes
Mar 12, 2023
defiantnerd
approved these changes
Mar 12, 2023
baconpaul
approved these changes
Mar 13, 2023
There was a problem hiding this comment.
Happy to approve
some comments for 1.9
optional const char* should be set to nullptr or a zero length string? I assume nullptr but let’s say this.
We are inconsistent in draft names. Foo.draft0 .draft-0 .draft/0. We should pick one
but these are both 1.9 things good to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.