8000 Comparing Yelp:master...freshworks:master · Yelp/dockersh · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Aug 28, 2019. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: Yelp/dockersh
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: freshworks/dockersh
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 12 commits
  • 739 files changed
  • 1 contributor

Commits on Aug 2, 2019

  1. Fix build and issues with latest docker

    - Vendor all the dependencies
    - Use 'go mod'
    - Minor fixes
      - Cannot pass "username" to dockerun, must pass "uid"
      - Update container config location
      - Pass current env when nsentering (TODO: Probably should use nsenter?)
      - Don't panic when docker is not installed
      - Fix 'go vet' errors
    surki committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    702760a View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2019

  1. Update to use docker api

    - Use docker client API
    - vendor all dependencies
    - Remove unused files
    surki committed Aug 8, 2019
    Configuration menu
    Copy the full SHA
    c4d9480 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2019

  1. Configuration menu
    Copy the full SHA
    3f6e791 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8dab1bf View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2019

  1. Add support for SCP

    surki committed Aug 28, 2019
    Configuration menu
    Copy the full SHA
    b16d810 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2019

  1. Fix "docker exec" orphan process

    When this "dockersh" process is signalled/killed (like when ssh disconnects
    due to network issue etc), due to a docker bug, processes that are running
    inside 'docker exec' are left as they are i.e., they will continue to
    run. This can add up quite a bit of processes over the time. See here for
    more information: moby/moby#9098
    
    Until that is fixed, we will handle it here by:
    
     - Have the pid of exec'ed bash at /tmp/dockersh-exec-${this_process_pid}
    
     - Install a signal handler here that will send SIGHUP to the pid stored in
       /tmp/dockersh-exec-${this_process_pid}
    surki committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    d40577a View commit details
    Browse the repository at this point in the history
  2. Cleanup entry script

    surki committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    d3e44f0 View commit details
    Browse the repository at this point in the history
  3. Add memory quota option

    TODO: Add CPU quota as well
    surki committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    b801a31 View commit details
    Browse the repository at this point in the history
  4. Add support for "gnu screen"

    surki committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    af08129 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2019

  1. Re-org "docker exec" cleanup

    It is possible that child process (i.e., "docker exec") can get SIGHUP and
    exit before dockersh process gets notified. So we will run docker exec
    cleanup in both cases.
    surki committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    3d601f5 View commit details
    Browse the repository at this point in the history
  2. Move entry point to Dockerfile

    surki committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    75e22c2 View commit details
    Browse the repository at this point in the history
  3. Add log to file support

    surki committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    33d1992 View commit details
    Browse the repository at this point in the history
Loading
0