8000 Unexpected behavior with --saveonexit · Issue #411 · gtkwave/gtkwave · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Unexpected behavior with --saveonexit #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
zapta opened this issue Feb 8, 2025 · 10 comments
Open

Unexpected behavior with --saveonexit #411

zapta opened this issue Feb 8, 2025 · 10 comments

Comments

@zapta
Copy link
zapta commented Feb 8, 2025

When I type gtkwave --help I am getting this flag help:

 -7, --saveonexit           prompt user to write save file at exit

However, when I try to use it, gtkwave doesn't prompts the user and saves the changes to the .gtkw file automatically. Is there a way to let the user decide if they want to save the changes to the .gtkw file?

gtkwave --saveonexit --rcvar "splash_disable on" --rcvar "do_initial_zoom_fit 1" _build/ledon_tb.vcd ledon_tb.gtkw
@tbybell
Copy link
Collaborator
tbybell commented Feb 8, 2025

To https://github.com/gtkwave/gtkwave.git
7ab46d5..36b88ba lts -> lts

I changed the behavior in LTS. Please see if it works for you. If this in master, it needs to be updated there too. I don't have a meson env set up at the moment as I've been running an old centos box for compatibility with some old tools.

@zapta
Copy link
Author
zapta commented Feb 8, 2025

Thanks @tbybell. Does gtkwave have nightly builds that I can try?

@tbybell
Copy link
Collaborator
8000
tbybell commented Feb 8, 2025

I don't know. I just use github as revision control. Ralf and others have been the ones who have set up all the extra stuff such as a QA build process and such since I turned gtkwave over to a gtkwave org account. Which version are you using and on what distribution or OS?

Note that I'm close to releasing 3.3.122 as it's been quite a while since the last release. If the save on exit with what is in LTS works for you, I'll do the release, but as for you, that's a bit chicken and egg.

@zapta
Copy link
Author
zapta commented Feb 8, 2025

I am using GTKWave Analyzer v3.4.0 (w)1999-2022 BSI on Mac OSX (apple silicon). It's downstream for the oss-cad-suite release. I just wanted to run the latest to test and provide you feedback for the fix.

@zapta
Copy link
Author
zapta commented Feb 8, 2025

.. I am not familiar with the organizational structure of gtkwave. Will your fix here will eventually included in the official releases?

@tbybell
Copy link
Collaborator
tbybell commented Feb 9, 2025

It should be. That behavior you discovered for this issue is a bug.

3.4.0 should be the new version Ralf is working on. The changes I made will have to get moved over to that branch. They can't be directly integrated as the changes in codebases are extensive. Builds are being run somewhere: I just haven't explored what is going on with the main branch lately. Ralf or someone else should be able to comment.

@zapta
Copy link
Author
zapta commented Feb 10, 2025

Thanks for the quick fix. I will look for it to be propagated to our project (https://github.com/FPGAwars/apio) via oss-cad-suite release.

@zapta zapta mentioned this issue Feb 10, 2025
Open
@zapta
Copy link
Author
zapta commented May 4, 2025

Hi @rfuest, @tbybell mentioned earlier your name in the context of upstream integration. Anything else need to happen for this change to propagate to the release?

@rfuest
Copy link
Collaborator
rfuest commented May 5, 2025

I can apply Tony's patch to the development branch, but there are no official releases of the development branch and there won't be any for quite some time. I think that oss-cad-suite uses an old version of the development branch that hasn't be updated for a long time.

@zapta
Copy link
Author
zapta commented May 5, 2025

Thanks @rfuest, oss-cad-suite indeed uses v3.4.0 but it's good if fixes do move in the pipeline toward the end users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rfuest @zapta @tbybell
0