8000 Legacy VCD loader is broken in GTKWave LTS · Issue #424 · gtkwave/gtkwave · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Legacy VCD loader is broken in GTKWave LTS #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rfuest opened this issue Apr 8, 2025 · 2 comments
Closed

Legacy VCD loader is broken in GTKWave LTS #424

rfuest opened this issue Apr 8, 2025 · 2 comments

Comments

@rfuest
Copy link
Collaborator
rfuest commented Apr 8, 2025

The legacy VCD loader is probably not used by anyone, but I noticed that this line refers to the wrong buffer which causes a segfault:

gtkwave/gtkwave3-gtk3/src/vcd.c

Line 343 in 6d759db

memset(GLOBALS->vcdbuf_vcd_recoder_c_3, 0, VCD_BSIZ);

@tbybell
Copy link
Collaborator
tbybell commented Apr 9, 2025

Introduced by me at 3.3.120, so it was fairly recent, at least as far as version numbers go:
Fix case of missing newline at EOF for VCD loaders.
Cut and paste directly from the recoder into the legacy loader = dead legacy loader. It only happened in the -gtk3 version so it was a totally sloppy cut-and-paste.

I'll check in the fix to LTS along with the other fixes that have been stacking up.

@tbybell
Copy link
Collaborator
tbybell commented Apr 9, 2025

To https://github.com/gtkwave/gtkwave.git
6d759db..1fec704 lts -> lts

@tbybell tbybell closed this as completed Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rfuest @tbybell
0