8000 Comparing main...pr4352 · guardian/grid · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: guardian/grid
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: guardian/grid
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: pr4352
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 12 commits
  • 21 files changed
  • 1 contributor

Commits on Dec 29, 2024

  1. Introduce an orientation metadata nested object on asset to capture d… 

    …ata about this image which could affect it's rendered orientation (ie. exif orientation tags).

Update elastic mapping fields
    @tonytw1
    tonytw1 committed Dec 29, 2024
    Configuration menu
    Copy the full SHA
    0dc3b4f View commit details
    Browse the repository at this point in the history

  2. Uploader captures orientation information.

    @tonytw1
    tonytw1 committed Dec 29, 2024
    Configuration menu
    Copy the full SHA
    b0e6dd5 View commit details
    Browse the repository at this point in the history

  3. Crops and thumbnails are corrected for orientation. 

    makeImgopsUri adds rotate parameter to preview image urls.
imgops rotates images counter-clockwise and ignores negative values/
    @tonytw1
    tonytw1 committed Dec 29, 2024
    Configuration menu
    Copy the full SHA
    c666a8e View commit details
    Browse the repository at this point in the history

  4. Source assert adds an optional orientedDimensions to allow clients li… 

    …ke the cropper to be told if orientation effects the rendered dimensions of this image.
    @tonytw1
    tonytw1 committed Dec 29, 2024
    Configuration menu
    Copy the full SHA
    e040e81 View commit details
    Browse the repository at this point in the history

  5. Cropper UI prefers source.orientedDimensions as the crop dimensions i… 

    …d the field is present for this image.
    @tonytw1
    tonytw1 committed Dec 29, 2024
    Configuration menu
    Copy the full SHA
    67c5fc9 View commit details
    Browse the repository at this point in the history

  6. Cropper validation uses oriented dimensions to be consistant with UI.

    @tonytw1
    tonytw1 committed Dec 29, 2024
    Configuration menu
    Copy the full SHA
    92a5d06 View commit details
    Browse the repository at this point in the history

  7. An optional CropSpec.rotation field records the rotation which was ap… 

    …plied when these bounds where selected; an EXIF orientation rotation will be explictly shown here.
    @tonytw1
    tonytw1 committed Dec 29, 2024
    Configuration menu
    Copy the full SHA
    2a479d5 View commit details
    Browse the repository at this point in the history

  8. ImageModelTest requires optional field to be fully populated.

    @tonytw1
    tonytw1 committed Dec 29, 2024
    Configuration menu
    Copy the full SHA
    0f3ee67 View commit details
    Browse the repository at this point in the history

  9. Add new Asset.orientation field is an optional top level portrait / l… 

    …andscape orientation.
    @tonytw1
    tonytw1 committed Dec 29, 2024
    Configuration menu
    Copy the full SHA
    278e00f View commit details
    Browse the repository at this point in the history

  10. Update mappings to include new orientation field.

    @tonytw1
    tonytw1 committed Dec 29, 2024
    Configuration menu
    Copy the full SHA
    6f15b06 View commit details
    Browse the repository at this point in the history

  11. orientation field can be set from plain dimensions for images which h… 

    …ave no orientation metadata.
    @tonytw1
    tonytw1 committed Dec 29, 2024
    Configuration menu
    Copy the full SHA
    c5ab5ba View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2025

  1. Merge c5ab5ba into fd86f05

    @tonytw1
    tonytw1 authored Feb 10, 2025
    Configuration menu
    Copy the full SHA
    daa6fed View commit details
    Browse the repository at this point in the history
Loading
0