8000 Grit checks checking filenames works differently on Windows · Issue #639 · honeycombio/gritql · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Grit checks checking filenames works differently on Windows #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
TheKnarf opened this issue May 12, 2025 · 2 comments
Open

Grit checks checking filenames works differently on Windows #639

TheKnarf opened this issue May 12, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@TheKnarf
Copy link
TheKnarf commented May 12, 2025 •
edited
Loading

This custom grit check works fine for me on MacOS, but fails on a colleagues computer running Windows.
It doesn't make sense that you can't use the same checks on different operating systems, GritQL should just normalize paths to always use the unix-standard. If not I'll have to have if-cases based on host OS in all of my tests?

Image
@TheKnarf
Copy link
Author

Is there even a way in GritQL to have an if-statement that switches based on host os?

@morgante morgante added the bug Something isn't working label May 13, 2025
@morgante
Copy link
Contributor

Agreed we should normalize the file paths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TheKnarf @morgante
0