8000 Significant lag when opening or collapsing folders. · Issue #33 · gfxholo/iconic · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Significant lag when opening or collapsing folders. #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SandmansDreams opened this issue Oct 20, 2024 · 6 comments · Fixed by #67
Closed

Significant lag when opening or collapsing folders. #33

SandmansDreams opened this issue Oct 20, 2024 · 6 comments · Fixed by #67
Labels
performance Laggy behavior caused by the plugin

Comments

@SandmansDreams
Copy link

It is as it says. About .5 - 2 second wait before the folder opens or collapses. This seems to be dependent on how many notes are in the folder, but some of these folders are full of only files and no folders or files with icons.
I am a beginner programmer, but if I were to take a guess, it might have something to do with checking the files before the folder opens to see if they have icons assigned or not. No idea why that would lag on collapse tho.
(Also, the icons that look like file icons are provided by the theme, not this plugin. Still have the same issue with that theme disabled.)
(Also also, I have the file color plugin on. I have disabled it and tested without and it seems to be fine as long as the iconic plugin is not enabled.)

image
image
@gfxholo
Copy link
Owner
gfxholo commented Oct 20, 2024 •
edited
Loading

Thanks for the report! If you've already confirmed the theme makes no difference, can you check whether the lag still exists when you disable all other plugins and CSS snippets?

I am a beginner programmer, but if I were to take a guess, it might have something to do with checking the files before the folder opens to see if they have icons assigned or not. No idea why that would lag on collapse tho.

It's related to this observer callback, which refreshes a folder's children when it gains or loses the is-collapsed class. It doesn't have to refresh on collapse — that's just lazy coding by me — but I've never seen it cause a performance hit until now.

@gfxholo
Copy link
Owner
gfxholo commented Nov 18, 2024

Hey @SandmansDreams, I'm just closing this issue for now because there's not enough info to understand why this slowdown happens for you. If you get time to narrow it down, come and reply here!

@gfxholo gfxholo closed this as not planned Won't fix, can't repro, duplicate, stale Nov 18, 2024
@SandmansDreams
Copy link
Author

Hey @SandmansDreams, I'm just closing this issue for now because there's not enough info to understand why this slowdown happens for you. If you get time to narrow it down, come and reply here!

Yea sorry, it happens on both my systems (mac and PC) and is definitely due to this plugin (as disabling it removes the lag) but I have no idea why it happens. Additionally, the more folders with icons it has, the longer it takes to open / collapse at a proportional rate. I did try turning off all plugins and CSS snippets and there is still some lag, though significantly less. If it was at that speed with everything enabled, I likely would not have noticed. Sorry for the late response.
My theory is it could be compounded with the other folder plugins I have (auto-collapse-folder and file color) that makes it much worse. However, it still seems that this plugin is contributing the most significant portion of lag.

@gfxholo
Copy link
Owner
gfxholo commented Jan 1, 2025 •
edited
Loading

Sorry about the radio silence - there's just nothing for me to report yet, since my focus has been on finishing a big feature update since October. I'll leave this issue open until I can properly test it with the two plugins you mentioned. (seems like it's a compatibility issue?)

Happy new year for now! 🎉

@gfxholo gfxholo reopened this Jan 1, 2025
@SandmansDreams
Copy link
Author

Sorry about the radio silence - there's just nothing for me to report yet, since my focus has been on finishing a big feature update since October. I'll leave this issue open until I can properly test it with the two plugins you mentioned. (seems like it's a compatibility issue?)

Happy new year for now! 🎉

No problem, get to it when you have time. Happy new year!

@gfxholo gfxholo added the performance Laggy behavior caused by the plugin label Jan 21, 2025
@Jessiii223 Jessiii223 mentioned this issue Jan 22, 2025
Merged
@gfxholo
Copy link
Owner
gfxholo commented Jan 25, 2025

Hi @SandmansDreams, another contributor put some elbow grease into alleviating this :) The changes are in the code now, and I'll release them as a patch soon with a few other fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance Laggy behavior caused by the plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Optimize Folder Icon Refresh to Improve Performance (#33) Jessiii223/iconic
2 participants
@SandmansDreams @gfxholo
0