8000 Engines hold filter duplicates · Issue #4266 · ghostery/adblocker · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Engines hold filter duplicates #4266
Open
@chrmod

Description

@chrmod

While testing FiltersEngine.merge we've noticed that engines are able to keep duplicated filters.

Steps to reproduce:

const engineBlob = fs.readFileSync(pathToEngine);
const engine = FiltersEngine.deserialise(engineBlob); 
const emptyEngine = FiltersEngine.empty(engine.config);
const newEngine = FiltersEngine.merge([engine, emptyEngine]);
assert(engine.getFilters().networkFilters.length === newEngine.getFilters().networkFilters.length);
assert(engine.getFilters().cosmeticFilters.length === newEngine.getFilters().cosmeticFilters.length);

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    0