8000 Try harder to avoid sharing cygheaps across MSYS2 runtime versions · Issue #4305 · git-for-windows/git · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Try harder to avoid sharing cygheaps across MSYS2 runtime versions #4305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dscho opened this issue Feb 21, 2023 · 1 comment
Closed

Try harder to avoid sharing cygheaps across MSYS2 runtime versions #4305

dscho opened this issue Feb 21, 2023 · 1 comment
Assignees
@dscho
Milestone
v2.40.0

Comments

@dscho
Copy link
Member
dscho commented Feb 21, 2023

In git-for-windows/msys2-runtime#48, we tried to make sure that Git for Windows' MSYS2 runtime does not even try to access the information in the cygheap of another MSYS2 runtime version.

However, the indicator used by this PR is the Cygwin version. That's not good enough because there are sometimes changes in Git for Windows' MSYS2 runtime that leave the Cygwin version alone.

For example, the recent backport of the fix for less hanging after a window resize left the MSYS2 runtime version at 3.3.6-341 but trying to use the cygheap across the previous and the current version of the MSYS2 runtime in Git for Windows simply leads to a terse exit code 127 without any other error message.

This workflow run demonstrates two instances of the symptoms: when calling gzip.exe from tar.exe where gzip.exe uses the current MSYS2 runtime while tar.exe uses the previous version, and when calling base64.exe that uses the previous MSYS2 runtime from a bash.exe that uses the current version.

While we have a PR to work around this issue in the open-pr workflow, a fuller fix is required e.g. to address actions/cache#1092 and actions/cache#1073.

Since Git v2.40.0-rc0 is just around the corner, we need to address this issue rather quickly.

My current idea is to add the information about the current commit via a new option of the MSYS2 runtime's ./configure and use that instead of the Cygwin runtime version when trying to avoid reusing cygheaps across processes.

As a bonus, this will allow us to adjust the output of uname -r to make it more useful.

A slight complication is that the actual build of the msys2-runtime package does not use the git-for-windows/msys2-runtime repository at all, but replays the commits directly on top of the tagged Cygwin revision. This means that we will have to patch not only configure.ac and friends in addition to adjusting the configure call in PKGBUILD, but we also have to adjust update-patches.sh to record the commit hash.
@dscho dscho self-assigned this Feb 21, 2023
@dscho dscho mentioned this issue Feb 21, 2023
Merged
@dscho dscho added this to the Next release milestone Feb 22, 2023
@dscho
Copy link
Member Author
dscho commented Feb 22, 2023 •
edited by gitforwindowshelper bot
Loading

/add release note bug When trying to call Cygwin (or for that matter, MSYS2) programs from Git Bash, users would frequently be greeted with cryptic error messages about a "cygheap" or even just an even more puzzling exit code 127. Many of these calls now succeed, allowing basic interactions. While it is still not possible for, say, Cygwin's vim.exe to interact with the Git Bash's terminal window, it is now possible for Cygwin's zstd.exe in conjuction with Git for Windows' tar.exe to handle .tar.zst archives.

The workflow run was started

@dscho dscho closed this as completed Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dscho dscho

Labels
None yet
Projects
None yet
Milestone
v2.40.0
Development

No branches or pull requests
1 participant
@dscho
0