Assist users with next steps... #414
Comments
|
More mind dumping on this... Some other projects use labels to help track the status of PRs. It could be useful with git as well.
|
|
I wonder whether we should do #152 instead, and then warn the user if the topic has either not been picked up for over a week, or has "fallen off the train" (i.e. has been in "What's cooking" but no longer is, despite the PR still being open). Particular attention could be paid to tell the user if their topic has been moved to the "Stalled" section. |
|
I think this might be a good start for that idea: /*
* This class is designed to parse the "What's cooking" mails sent to
* the Git mailing list about twice a week by the Git maintainer.
*/
export class SousChef {
protected readonly mbox: string;
protected readonly messageID: string | undefined;
protected readonly branches: {
[branchName: string]: {
merged: string | undefined;
sectionName: string;
text: string;
}
};
public constructor(mbox: string) {
this.mbox = mbox;
this.branches = {};
const sections = mbox.split(/^-{10,}\n\[([^\]]+)\]\n/mg)
for (let i = 1; i < sections.length; i += 2) {
const sectionName = sections[i]
const branches = sections[i + 1].split(/\n\* ([a-z][^]+?)\n\n/m);
for (let j = 1; j < branches.length; j += 2) {
const match = branches[j]
.match(/([^ ]+).*\n *(\(merged to [^)]+\))?/m);
if (!match) continue;
const branchName = match[1];
const merged = match[2];
const text = branches[j + 1];
this.branches[branchName] = { merged, sectionName, text };
}
}
const messageIDMatch =
`\n${sections[0]}`.match(/\nMessage-ID: <([^>]+)>/im)
this.messageID = messageIDMatch?.[1];
}
} |
I think those are very good ideas. |
Suggested (among other suggestions) in gitgitgadget#414 (comment) Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Suggested (among other suggestions) in gitgitgadget#414 (comment) Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Suggested (among other suggestions) in gitgitgadget#414 (comment) Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Users are not always inclined to study the doc. Having submitted a change it is not always obvious what to do next if there are some email exchanges and possibly new /submitted changes. This can cause changes to linger that would otherwise be ready to be integrated. It would be helpful to notify users an action may be required on their part to move a patch forward. Automated posting of a comment on 'quiet' PRs with suggestions could be useful. When a patch is ready to move forward after some exchanges and updates, the Git maintainer needs to be notified. A command to do this would be helpful (ie /mergeready, /ready2merge, /mergable, ...?).
PR #410 has the initial discussion of this issue. Something like actions/stale does some of the work. There may be other workflows providing more features.
The text was updated successfully, but these errors were encountered: