8000 Commit Checks · Issue #818 · gitgitgadget/gitgitgadget · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Commit Checks #818
Open
Open
@softworkz

Description

@softworkz

if (this.commitViable()) {
this.commitMessageLength();
this.bangPrefix();
this.lowerCaseAfterPrefix();
this.signedOffBy();
this.moreThanAHyperlink();
}

The requirements are similar to ours but there are differences, so it's moot to discuss individual ones. Just the above seems a bit odd:

  • at first, you might get a reply that says your message would be too short
    • you might end up writing a longer message, but you still get the same reply
    • because it is not checking for message length at all but for additional lines instead
  • The above condition can be satisfied, alone by adding signed-off
  • Only after having satisfied the initial condition (msg length), you get the others, e.g. : capitalization
    • make you wonder: "hey, why didn't it say that in the first place?"

I just wonder why it's done that way..

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0