Normalize arguments unused

It seems that the boolean arguments are left completely unused in favor of what's in gOpts. I am not sure whether the intended behavior here is to always use what's in gOpts, to always use what's passed in, or some hybrid behavior but as-is these arguments can be completely removed without changing any behavior.

lf/nav.go

Lines 199 to 209 in 6abce04

    
           func normalize(s1, s2 string, ignorecase, ignoredia bool) (string, string) { 
        
           	if gOpts.ignorecase { 
        
           		s1 = strings.ToLower(s1) 
        
           		s2 = strings.ToLower(s2) 
        
           	} 
        
           	if gOpts.ignoredia { 
        
           		s1 = removeDiacritics(s1) 
        
           		s2 = removeDiacritics(s2) 
        
           	} 
        
           	return s1, s2 
        
           }

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

	func normalize(s1, s2 string, ignorecase, ignoredia bool) (string, string) {
	if gOpts.ignorecase {
	s1 = strings.ToLower(s1)
	s2 = strings.ToLower(s2)
	}
	if gOpts.ignoredia {
	s1 = removeDiacritics(s1)
	s2 = removeDiacritics(s2)
	}
	return s1, s2
	}

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions