8000 `Field` regressions due to #8738 · Issue #9005 · google/blockly · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Field regressions due to #8738 #9005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task done
cpcallen opened this issue May 7, 2025 · 0 comments
Closed
1 task done

Field regressions due to #8738 #9005

cpcallen opened this issue May 7, 2025 · 0 comments
Assignees
@gonfunko
Labels
injection issue: bug Describes why the code or behaviour is wrong

Comments

@cpcallen
Copy link
Contributor
cpcallen commented May 7, 2025 •
edited
Loading

Check for duplicates

  • I have searched for similar issues before opening a new one.

Description

PR #8738 fixed issue #8738, but introduced a number of unexpected changes to fields:

  1. Remove of Field.NBSP broke the multiline text input field in a trivial but somewhat gratuitous way.
  2. Removal of code that ensures field display text is at least one character long caused empty inputs to become quite narrow:
    • Before:
      Image
    • After:
      Image
  3. Removal of code that replaces normal spaces with non-breaking spaces causes fields with multiple consecutive spaces to be mis-rendered:
    • Before:
      Image
    • After:
      Image

Reproduction steps

  1. Open playground.
  2. Drag any block with a FieldInput to the workspace.
  3. Enter the empty string.
  4. Enter text with multiple spaces.

Additional observations

  • The change to make empty label fields zero-width appears to be correct and should be retained.
  • It's pretty clear that FieldInput at should have the previous multiple-space-retention behaviour. It's less clear whether ordinary Fields should too, but it looks like there will be a rendering bug if they don't.
  • There doesn't seem to be any reason that empty FieldInputs should be revert to the previous, slightly wider width:
@cpcallen cpcallen added issue: bug Describes why the code or behaviour is wrong issue: triage Issues awaiting triage by a Blockly team member labels May 7, 2025
@cpcallen cpcallen changed the title Field gegressions due to #8738 Field regressions due to #8738 May 7, 2025
@sappm01 sappm01 moved this to Todo in Blockly Accessibility May 7, 2025
@gonfunko gonfunko mentioned this issue May 7, 2025
Merged
1 task
@sappm01 sappm01 moved this from Todo to In Progress in Blockly Accessibility May 7, 2025
@maribethb maribethb removed the issue: triage Issues awaiting triage by a Blockly team member label May 9, 2025
@gonfunko gonfunko moved this from In Progress to Done in Blockly Accessibility May 13, 2025
@gonfunko gonfunko closed this as completed by moving to Done in Blockly Accessibility May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gonfunko gonfunko

Labels
injection issue: bug Describes why the code or behaviour is wrong
Projects
Blockly Accessibility
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gonfunko @cpcallen @maribethb @sappm01
0