fix(js): an issue with loose equality for helpers; add missing tests for some helpers #53 #54 #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for some helpers #53 #54 RATIONALE: Loose equality as espoused by JavaScript's coercive operators, e.g. `==` will not translate to Python and Go. Since these tests expect cross-runtime behavior to be consistent, we also ensure that they are type-safe across language runtimes. ISSUES: - [x] #53 (strict equality) - [x] #54 (missing helpers) CHANGELOG: - [x] Add YAML spec tests for these helpers: - [x] history - [x] ifEquals - [x] section - [x] unlessEquals - [x] Strict equality for ifEquals and unlessEquals - [x] Add commentary explaining each test to help understanding - [x] Update the Git hooks to run JS tests.
This was
linked to
issues
Feb 19, 2025
|
I'm also wondering whether there needs to be some way to filter certain tests based on the runtime. |
mbleigh
approved these changes
Feb 19, 2025
This was referenced Mar 25, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(js): an issue with loose equality for helpers; add missing tests for some helpers #53 #54
RATIONALE:
Loose equality as espoused by JavaScript's coercive operators, e.g.
==will not translate to Python and Go. Since these tests expect cross-runtime behavior to be consistent, we also ensure that they are type-safe across language runtimes.ISSUES:
CHANGELOG: