8000 feat(go/parse): parse.go implementation #62 by yesudeep · Pull Request #87 · google/dotprompt · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(go/parse): parse.go implementation #62 #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2025
Merged

feat(go/parse): parse.go implementation #62 #87

merged 1 commit into from
Feb 28, 2025

Conversation

yesudeep
Copy link
Collaborator
@yesudeep yesudeep commented Feb 27, 2025 •
edited
Loading

feat(go/parse): parse.go implementation #62

ISSUES:

CHANGELOG:

  • Add an implementation of parse.ts for Go in parse.go and
    associated tests in parse_test.go
  • Add some utility functions in util.go and associated tests in util_test.go
  • Small fixes here and there to the TS and Py implementations.
  • Update the testing threshold for TS.

@yesudeep yesudeep force-pushed the yesudeep/feat/go-parse branch from 6ea993e to d718ed6 Compare February 27, 2025 22:05
@yesudeep yesudeep changed the title feat(go/parse): parse.go implementation feat(go/parse): parse.go implementation #62 Feb 27, 2025
@yesudeep yesudeep requested a review from rutujaD1999 February 27, 2025 22:12
@yesudeep yesudeep force-pushed the yesudeep/feat/go-parse branch 2 times, most recently from 76c4d5c to c07751f Compare February 27, 2025 22:34
@yesudeep yesudeep linked an issue Feb 27, 2025 that may be closed by this pull request
[Go] Implement parse.ts in Go #62
Closed
@yesudeep yesudeep force-pushed the yesudeep/feat/go-parse branch 6 times, most recently from bd6b4ee to 41a50cd Compare February 28, 2025 00:13
@yesudeep
feat(go/parse): parse.go implementation #62
ae6a5bc 
ISSUES:
- [ ] #62

CHANGELOG:
- [ ] Add an implementation of parse.ts for Go in parse.go and
  associated tests in parse_test.go
- [ ] Add some utility functions in util.go and associated tests in util_test.go
- [ ] Small fixes here and there to the TS and Py implementations.
- [ ] Update the testing threshold for TS.
@yesudeep yesudeep force-pushed the yesudeep/feat/go-parse branch from 41a50cd to ae6a5bc Compare February 28, 2025 00:15
@yesudeep yesudeep requested a review from pavelgj February 28, 2025 00:16
@yesudeep
Copy link
Collaborator Author

cc: @apascal07 please leave comments on the PR when you're back. I'll address them in follow up PRs. Merging to move faster.

@yesudeep yesudeep merged commit d5dc13c into main Feb 28, 2025
15 checks passed
@yesudeep yesudeep deleted the yesudeep/feat/go-parse branch February 28, 2025 00:17
This was referenced Mar 25, 2025
Closed
Open
Open
Open
@rutujaD1999 rutujaD1999 mentioned this pull request Apr 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanyasingh1902 tanyasingh1902 tanyasingh1902 approved these changes

@mbleigh mbleigh Awaiting requested review from mbleigh

@apascal07 apascal07 Awaiting requested review from apascal07

@rutujaD1999 rutujaD1999 Awaiting requested review from rutujaD1999

@pavelgj pavelgj Awaiting requested review from pavelgj

Assignees
No one assigned
Labels
config dotpromptz feature go js python
Projects
Dotprompt
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Go] Implement parse.ts in Go
2 participants
@yesudeep @tanyasingh1902
0