8000 fix headers includes in double conversion · Issue #91 · google/double-conversion · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
fix headers includes in double conversion #91
Closed
@Neumann-A

Description

@Neumann-A

all double-conversion headers should be correctly included with "" instead of <>

example:
#include <double-conversion\utils.h>
should be changed to
#include "utils.h"

you are generating build failures due to that using cmake....
also system includes are not meant to be used for internal headers... also your are vulnerable to including the wrong utils.h using system headers.
Example:
Two folders:
double-conversion
double-conversion_v2

double-conversion_v2 will include the headers from double-conversion instead of double-conversion_v2

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0