10000 The assert_variant macro clashes with other libraries · Issue #8769 · google/filament · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
The assert_variant macro clashes with other libraries #8769
Open
@merwaaan

Description

@merwaaan

Describe the bug

When using Filament in a project that also uses the commonly used nlohmannJSON library, Filament's assert_invariant macro conflicts with nlohmann's assert_invariant function.

To Reproduce

Steps to reproduce the behavior:

  1. Integrate nlohmann into a project using Filament
  2. Include nlohmann's headers

This causes the compilation to fail.

Expected behavior

Filament should not clash with other libraries because of global identifiers.
The macro could be prefixed or converted to a scoped function.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    0