8000 RequireCodeOwnerReviews cannot be set to false when updating · Issue #2286 · google/go-github · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
RequireCodeOwnerReviews cannot be set to false when updating #2286
New issue
New issue
Closed
#2289
Closed
RequireCodeOwnerReviews cannot be set to false when updating#2286
#2289
Labels
Breaking API ChangePR will require a bump to the major version num in next release. Look here to see the change(s).
@leopoldwang

Description

@leopoldwang
leopoldwang
opened on Feb 11, 2022

RequireCodeOwnerReviews field does not use pointer type causing json encode to omit the field. Request was then rejected by github rest api

go-github/github/repos.go

Line 948 in 2be8000

RequireCodeOwnerReviews bool `json:"require_code_owner_reviews,omitempty"`

Metadata

Metadata

Assignees

No one assigned

    Labels

    Breaking API ChangePR will require a bump to the major version num in next release. Look here to see the change(s).

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions
      0