8000 Support pulling only runID from Custom Deployment Protection Rule Events · Issue #3473 · google/go-github · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Support pulling only runID from Custom Deployment Protection Rule Events #3473
Closed
@pputman-clabs

Description

@pputman-clabs

In:
https://github.com/google/go-github/blob/v69.0.0/github/actions_workflow_runs.go#L521

We require a RunID argument in order to respond back to and authorize/deny a deployment.

Currently it looks like the only way to get the runID, is from the *github.DeploymentProtectionRuleEvent.DeploymentCallbackURL
which contains the entire callback URL, not just the runID. Since the function only needs the runID and not the string, the options are to either:

  1. Use a post request directly with this URL rather than using the library.
  2. Use regex to strip the runID from this URL, just to use it with this function which adds it right back into the same URL it was stripped out of.

It would be much cleaner if we could just use the callback URL as an option to the function, or if the event had a field that was just the RunID and not the entire url string

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    0