8000 Simplify secret.generic syntax · Issue #481 · google/heir · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Simplify secret.generic syntax #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
j2kun opened this issue Mar 5, 2024 · 1 comment
Closed

Simplify secret.generic syntax #481

j2kun opened this issue Mar 5, 2024 · 1 comment
Assignees
@j2kun
Labels
dialect: secret Issues related to the secret dialect

Comments

@j2kun
Copy link
Collaborator
j2kun commented Mar 5, 2024

It's currently

secret.generic ins(%arg0, %arg1 : secret<ty0>, secret<ty1>) {
^bb0(%arg0: ty0, %arg1: ty1):
  ...ops...
}

The discrepancy between how the ins part is parsed/printed vs the basic block is just confusing. We should probably change it to something like this

secret.generic (%arg0: secret<ty0>, %arg1 : secret<ty1>) {
^bb0(%arg0: ty0, %arg1: ty1):
  ...ops...
}
@j2kun j2kun added the dialect: secret Issues related to the secret dialect label Mar 5, 2024
@j2kun j2kun self-assigned this Mar 5, 2024
@j2kun j2kun mentioned this issue Dec 29, 2024
Closed
@ZenithalHourlyRate
Copy link
Collaborator

Fixed by #1793

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@j2kun j2kun

Labels
dialect: secret Issues related to the secret dialect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@j2kun @ZenithalHourlyRate
0