8000 Audience Segmentation oAuth Setup interrupted by another banner in queue · Issue #10890 · google/site-kit-wp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Audience Segmentation oAuth Setup interrupted by another banner in queue #10890
Open
@wpdarren

Description

@wpdarren

Bug Description

When clicking on the Enable Groups CTA on the Audience Segmentation Setup CTA banner, I am taken through the oAuth to login to my Google account and give permissions, and when I am redirected back to the dashboard, the Audience Segmentation widget does not appear on the dashboard and no success notification appears.

You can see the issue in the screencast below.

AS.mp4

Update: The issue appears to be because another banner with the same or higher priority than the AS setup banner appears in its place, which prevents the setup logic from continuing. If you dismiss the new banner, i.e. SiWG, the AS one reappears and continues with the setup. The fix will be to ensure the AS banner always has top priority when returning from OAuth; this is probably something we need to think of more generally, though, as part of the banner notification refactor.

10890-triage-audience-seg-bug.mp4

Steps to reproduce

  1. Set up Site Kit with Analytics.
  2. Ensure that the Search console and Analytics is in zero data state.
  3. Refresh the dashboard and the Audience Segmentation setup CTA will appear
  4. Click on the Enable Groups CTA and go through the steps.
  5. Observe that when you come back to the dashboard that the widget does not load and no success notification appears on the dashboard.

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • Any notification, that consists of a page reload (e.g. to take the user to oAuth) between multiple "steps" should always load its latter steps fully until that notification is actioned.
    • Currently, this applies to the Audience Segmentation Setup CTA Widget as well as the Enhanced Measurement Banner flows.
    • No other notification should interrupt the flow, causing the setup to fail.

Implementation Brief

Test Coverage

QA Brief

Changelog entry

Metadata

Metadata

Assignees

Labels

Module: AnalyticsGoogle Analytics module related issuesNext UpIssues to prioritize for definitionP0High priorityTeam MIssues for Squad 2Type: BugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    0