Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 3 commits
- 9 files changed
- 3 contributors
Commits on Jul 17, 2023
-
Change-Id: I496265fcad6dee919eff6fc1fbcf9121ae61730f Reviewed-on: https://go-review.googlesource.com/c/text/+/509855 Reviewed-by: Ian Lance Taylor <iant@google.com> Run-TryBot: Ian Lance Taylor <iant@google.com> Reviewed-by: Heschi Kreinick <heschi@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Auto-Submit: Ian Lance Taylor <iant@google.com>
Commits on Jul 20, 2023
-
The existing implementation has misbehaviors described in golang/go#56842: - `gotext extract` ignores `lang` flag - `gotext generate` ignores `out` flag - Misbehavior of `gotext generate` when no flag specified This commit fixes these bugs: - Update `Command.UsageLine` for `cmdGenerate` - Fix flag misbehaviors by encapsuling flag definition statements into individual `Command.Init()` functions of commands - Fix `gotext generate` misbehavior by executing `pipeline.State.Merge()` before `pipeline.State.Generate()` Fixes golang/go#56842 Change-Id: Id5e324b573b2b389bec22181482a97445230d0cc Reviewed-on: https://go-review.googlesource.com/c/text/+/452115 Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com> Reviewed-by: Marcel van Lohuizen <mpvl@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Commits on Jul 21, 2023
-
cmd/gotext: actually use -dir flag
gotext has the read -dir flag but is not used. The dir parameter should be passed to pipeline.Config Fixes golang/go#61507 Change-Id: I242a768964fe56c4c7877de9dc487777c6815dae Reviewed-on: https://go-review.googlesource.com/c/text/+/512015 Auto-Submit: Ian Lance Taylor <iant@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com> Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by: Ian Lance Taylor <iant@google.com> Run-TryBot: Ian Lance Taylor <iant@google.com>
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v0.11.0...v0.12.0