10000 x/tools/gopls: deprecate the "allowImplicitNetworkAccess" setting · Issue #66860 · golang/go · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

x/tools/gopls: deprecate the "allowImplicitNetworkAccess" setting #66860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
findleyr opened this issue Apr 16, 2024 · 1 comment
Closed

x/tools/gopls: deprecate the "allowImplicitNetworkAccess" setting #66860

findleyr opened this issue Apr 16, 2024 · 1 comment
Assignees
@findleyr
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.16.0

Comments

@findleyr
Copy link
Member

Gopls has long had an experimental setting to allow network access for all go command invocations: "allowImplicitNetworkAccess".

We should not have settings that affect low level behavior like this, as such settings are inevitably insufficiently tested and hard to maintain. Gopls should work well with its default decisions about allowing network access.

This issue tracks officially deprecating this setting in gopls@v0.16.0, to be removed in gopls@v0.17.0 (as we've been doing for these sorts of settings).
@findleyr findleyr added this to the gopls/v0.16.0 milestone Apr 16, 2024
@findleyr findleyr self-assigned this Apr 16, 2024
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Apr 16, 2024
@findleyr findleyr mentioned this issue Apr 16, 2024
Closed
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/579437 mentions this issue: gopls/internal/settings: deprecate "allowImplicitNetworkAccess"

@ghost ghost mentioned this issue Aug 30, 2024
Closed
@golang golang locked and limited conversation to collaborators Apr 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@findleyr findleyr

Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.16.0
Development

No branches or pull requests
2 participants
@gopherbot @findleyr
0