10000 🖥 🔧 React + Mobx · Issue #33 · gothinkster/realworld · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

🖥 🔧 React + Mobx #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
8000
3 of 5 tasks
robbiedhickey opened this issue Apr 24, 2017 · 22 comments
Closed
3 of 5 tasks

🖥 🔧 React + Mobx #33

robbiedhickey opened this issue Apr 24, 2017 · 22 comments
Labels
frontend rfc

Comments

@robbiedhickey
Copy link
robbiedhickey commented Apr 24, 2017 •
edited by sandeesh
Loading

Current Status

Todo:

  • 🏁 Fork the starter repo & post the link in this issue
  • 🎨 Create logo for repo & update issue status (@EricSimons)
  • 🔨 Implement all of Conduit's functionality per the spec & API
  • 👀 Peer review of final codebase by RealWorld admins & community (RFC)
  • 🎉 Tag v1 release, move repo to main org, and officially list it on the README!

I believe the React community would benefit from more examples of Mobx architectures juxtaposed against Redux in non-trivial applications. The only example I'm aware of is the SoundCloud Client developed by the excellent @rwieruch

I'm still getting my feet wet in the React ecosystem, but will take this on if there is not interest from a more experienced member in the community.
@robbiedhickey
Copy link
Author

I looked into the starter kit, but it occurred to me that it might make more sense to fork the existing React + Redux example app and refactor reducers to @observable stores. Any drawbacks to this approach?

I started a fork that adds the Mobx dependencies and migrates to custom-react-scripts to enable decorator support.

@rwieruch
Copy link

Thanks for mentioning. Just to give you some resources:

@EricSimons
Copy link
Member

@hodorswit I think your approach is perfect — no need to reinvent the React parts of the app :)

Regarding finding someone w/ more experience, @mweststrate do you know of anyone? Or perhaps someone that could provide advice to @hodorswit as he builds it out?

@EricSimons EricSimons added the wip label Apr 24, 2017
@EricSimons
Copy link
Member

@hodorswit I just updated the issue status + set up a Gitter room where we can handle collaborator coordination 👍

@mweststrate
Copy link

@capaj @andykog @benjamingr @mattruby anybody interested? ^

@benjamingr
Copy link

@mosho1

@mweststrate
Copy link

[Completely offtopic] @mosho1: Wondering about it since Friday, since I forgot to ask it, but did we meet last Friday without me realizing it? ;-) [/Completely offtopic]

@mattruby
Copy link

I'm out on this one. Yoyo exhibition tomorrow I need to prep for!

@andykog
Copy link
andykog commented Apr 24, 2017

I love the idea, will try to allocate some time tomorrow

@EricSimons
Copy link
Member

@hodorswit wanna add @andykog to the repo & coordinate work? Feel free to use the gitter room I set up for this Mobx implementation if need be :)

@EricSimons EricSimons changed the title React + Mobx [Frontend] 🖥 React + Mobx [Frontend] Apr 24, 2017
@EricSimons EricSimons changed the title 🖥 React + Mobx [Frontend] 🖥 React + Mobx [Frontend] Apr 24, 2017
@EricSimons EricSimons changed the title 🖥 React + Mobx [Frontend] 💻 React + Mobx [Frontend] Apr 24, 2017
@EricSimons EricSimons changed the title 💻 React + Mobx [Frontend] 🖥🔧 React + Mobx [Frontend] Apr 24, 2017
@EricSimons EricSimons changed the title 🖥🔧 React + Mobx [Frontend] 🖥 🔧 React + Mobx [Frontend] Apr 24, 2017
@EricSimons EricSimons changed the title 🖥 🔧 React + Mobx [Frontend] 🖥 🔧 React + Mobx Apr 24, 2017
@srolel
Copy link
srolel commented Apr 25, 2017

@benjamingr @hodorswit I'll see if I have time to take a jab at it this weekend. And no, @mweststrate, sadly we did not meet :P

@robbiedhickey
Copy link
Author

Just added @mosho1 and @andykog to the repo!

@andykog
Copy link
andykog commented May 6, 2017 •
edited
Loading

Done, see hodorswit/react-mobx-realworld-example-app
Replaced redux with mobx, added/modified a few components here and there. Used singletone stores for simplicity.

@EricSimons EricSimons added rfc and removed wip labels May 8, 2017
@EricSimons
Copy link
Member

Woot! Can one of the MobX folks here take a peek at @andykog's codebase and provide feedback (and/or approve it)? 💪

@mweststrate
Copy link

@EricSimons will try to check later today / tomorrow

@mweststrate
Copy link

@andykog wot that was quite an endeavour! looking good and idiomatic!

Didn't check all the components, but a small thing I noticed in the stores: ArticleStore has both articles and articlesRegistery. Could articles be expressed as @computed get articles() { return this.articlesRegistery.values() }?

@andykog
Copy link
andykog commented May 11, 2017

@mweststrate, I think arrays are generally better suited for managing order, but in our case you proposition should work great. Thanks for the review!

@andykog
Copy link
andykog commented May 11, 2017

(done)

@EricSimons
Copy link
Member
EricSimons commented May 16, 2017 •
edited by sandeesh
Loading

@andykog @hodorswit just added you both to the 'offical' repo — also have react-mobx.realworld.io pointed to github pages, so feel free to set up GH pages branch and it will show up live at that URL :)

@EricSimons
Copy link
Member

Just added the repo to the main README btw — amazing work guys! 👍 💯

Lmk when you have the GH pages set up & I'll close out this issue

@robbiedhickey
Copy link
Author

@EricSimons The demo is running via gh-pages at the following URL https://gothinkster.github.io/react-mobx-realworld-example-app 👍

For some reason the https://react-mobx.realworld.io URL is 404'ing. Is it worthwhile to troubleshoot this or do you think the default gh-pages link is fine?

@anishkny
Copy link
Member

https://react-mobx.realworld.io is up now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
frontend rfc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@mattruby @robbiedhickey @anishkny @EricSimons @benjamingr @mweststrate @rwieruch @srolel @andykog
0