[teleport-update] Change strategy for disabling teleport-upgrade timer #54062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugoShaka
reviewed
Apr 16, 2025
hugoShaka
approved these changes
Apr 16, 2025
vapopov
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current strategy for disabling the teleport-upgrade script when teleport-update is enabled does not work in some cases:
teleport-ent-updaterpackage is reinstalled.While teleport-upgrade cannot actually upgrade the updater-managed version of Teleport, it can result in Teleport restarting in certain cases where the advertised versions for Managed Updates v1 and v2 drift.
This PR switches to a different strategy. A drop-in is used to replace the
teleport-upgrade.servicecommand.This has a few advantages over
systemctl mask:teleport-ent-updaterbeing uninstalled and reinstalled.changelog: teleport-update: ensure teleport-upgrade is always disabled when teleport-update is used.
The
teleport-updatebinary is used to enable, disable, and trigger automatic Teleport agent updates. The new Managed Updates system manages a local installation of the cluster-specified version of Teleport stored in/opt/teleport.RFD: #47126
Goal (internal): https://github.com/gravitational/cloud/issues/11856