8000 Refactor function generate_sql to use crate sql_builder · Issue #6 · htmfilho/csvsource · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Refactor function generate_sql to use crate sql_builder #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
htmfilho opened this issue May 23, 2022 · 0 comments
895B
Open

Refactor function generate_sql to use crate sql_builder #6

htmfilho opened this issue May 23, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@htmfilho
Copy link
Owner
htmfilho commented May 23, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.

According to feedback from the community, the function generate_sql is complex and can be simplified by using an existing library to generate sql.

Describe the solution you'd like

The crate sql_builder seems to be a good option: https://docs.rs/sql-builder/latest/sql_builder/

Describe alternatives you've considered

The current implementation fulfills the needs of the project. Using sql_builder could simplify the code, but it can also increase its footprint. A lot of features in that library are not applicable in this project.
@htmfilho htmfilho added the enhancement New feature or request label May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@htmfilho
0