socket connection retry mechanism doesn't work in some situations #186

weyou · 2021-03-15T06:45:06Z

It looks like the socket connection retry mechanism doesn't work in some situations.

    def _conn_request(self, conn, request_uri, method, body, headers):
        i = 0
       ...
        while i < RETRIES:
            i += 1        # <------ here variable i becomes 1
            try:
                if conn.sock is None:
                    conn.connect()
                conn.request(method, request_uri, body, headers)
                ...
            except http.client.HTTPException:
                if conn.sock is None:
            ...

The global variable RETRIES is hardcoded into 2 currently. So the following code will never be executed since i always greater or equal than RETRIES - 1

                    if i < RETRIES - 1:
                        conn.close()
                        conn.connect()
                        continue
                    else:
                        conn.close()
                        raise
                if i < RETRIES - 1:
                    conn.close()
                    conn.connect()
                    continue

Maybe httplib2 allow user to change the value of httplib2.RETRIES. then above code block is reasonable.

But the second place:

            try:
                response = conn.getresponse()
            except :
            ...

The i always greater than 0, so the following code block will never be executed.

            except (socket.error, http.client.HTTPException):
                conn.close()
                if i == 0:
                    conn.close()
                    conn.connect()
                    continue

The text was updated successfully, but these errors were encountered:

temoto · 2021-03-15T06:59:31Z

Yes, it is dead code. Thank you.

It's better in Python2 version

                if i < RETRIES - 1:

https://github.com/httplib2/httplib2/blob/master/python2/httplib2/__init__.py#L1603-L1610

monluk · 2022-05-23T13:45:49Z

Wouldn't it be better to remove "- 1" from the lines pointed in the bug report, so that there is "i < RETRIES"?
There are still people using that version and Python 2.

temoto added the bug label Mar 15, 2021

monluk added a commit to monluk/httplib2 that referenced this issue May 23, 2022

httplib2#186 Fix retry mechanism

914e881

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

socket connection retry mechanism doesn't work in some situations #186

socket connection retry mechanism doesn't work in some situations #186

socket connection retry mechanism doesn't work in some situations #186

socket connection retry mechanism doesn't work in some situations #186

Comments