From 8b75c18f8b79bb3e5714beea12cf09f641b19c94 Mon Sep 17 00:00:00 2001 From: Dima Golovinov Date: Mon, 23 Jan 2023 15:39:48 +0100 Subject: [PATCH 01/18] Add Qodana WF --- .github/workflows/qodana.yml | 39 ++++++++++++++++++++++++++++++++++++ 1 file changed, 39 insertions(+) create mode 100644 .github/workflows/qodana.yml diff --git a/.github/workflows/qodana.yml b/.github/workflows/qodana.yml new file mode 100644 index 000000000..74386d29c --- /dev/null +++ b/.github/workflows/qodana.yml @@ -0,0 +1,39 @@ +name: QodanaCustomImageJob +on: + workflow_dispatch: + pull_request: + push: + branches: + - main + - dev + - 'releases/*' + +jobs: + qodana: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v3 + with: + fetch-depth: 0 + - name: Login to Jetbrains Space + uses: docker/login-action@v2 + with: + registry: registry.jetbrains.team + username: Dmitry.Golovinov + password: ${{ secrets.SPACE_PASSWORD }} + - run: docker pull registry.jetbrains.team/p/sa/containers/qodana-dotnet:231.5593.88.172 + - name: 'Qodana Scan' + uses: JetBrains/qodana-action@v5.1.0 + with: + args: "--linter,registry.jetbrains.team/p/sa/containers/qodana-dotnet:231.5593.88.172,--changes" + - name: 'Deploy to GitHub Pages' + uses: peaceiris/actions-gh-pages@v3 + with: + github_token: ${{ secrets.GITHUB_TOKEN }} + publish_dir: ${{ runner.temp }}/qodana/results/report + destination_dir: ./ + - name: 'Upload artifacts' + uses: actions/upload-artifact@v3 + with: + name: results + path: ${{ runner.temp }}/qodana/results/ From 31451cb57973ffcb0c42adcb5855727c8516744f Mon Sep 17 00:00:00 2001 From: Dima Golovinov Date: Mon, 23 Jan 2023 15:42:23 +0100 Subject: [PATCH 02/18] Committing old code --- rd-net/Lifetimes/Core/Maybe.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/rd-net/Lifetimes/Core/Maybe.cs b/rd-net/Lifetimes/Core/Maybe.cs index e8e780c77..1018e7832 100644 --- a/rd-net/Lifetimes/Core/Maybe.cs +++ b/rd-net/Lifetimes/Core/Maybe.cs @@ -50,6 +50,7 @@ public T OrElseThrow(Func func) public override bool Equals(object obj) { + var a = 5; if (!(obj is Maybe)) return false; return Equals((Maybe)obj); } From 0b89f6e1b20724d5642575dc72c5acf2048dc3e5 Mon Sep 17 00:00:00 2001 From: Dima Golovinov Date: Mon, 23 Jan 2023 16:17:08 +0100 Subject: [PATCH 03/18] remove all other --- .github/workflows/build-rd-cpp.yml | 207 ------------------ .github/workflows/build-rd-kt-container.yml | 41 ---- .github/workflows/build-rd-kt.yml | 42 ---- .github/workflows/build-rd-net.yml | 30 --- .github/workflows/qodana.yml | 4 +- .github/workflows/release-rd-cpp.yml | 224 -------------------- 6 files changed, 2 insertions(+), 546 deletions(-) delete mode 100644 .github/workflows/build-rd-cpp.yml delete mode 100644 .github/workflows/build-rd-kt-container.yml delete mode 100644 .github/workflows/build-rd-kt.yml delete mode 100644 .github/workflows/build-rd-net.yml delete mode 100644 .github/workflows/release-rd-cpp.yml diff --git a/.github/workflows/build-rd-cpp.yml b/.github/workflows/build-rd-cpp.yml deleted file mode 100644 index 5064e6dd3..000000000 --- a/.github/workflows/build-rd-cpp.yml +++ /dev/null @@ -1,207 +0,0 @@ -name: build-rd-cpp - -on: - push: - branches: [ master ] - pull_request: - branches: [ master ] - -env: - NINJA_VERSION: 1.9.0 - BUILD_TYPE: Release - -jobs: - build: - env: - working-dir: ${{ github.workspace}}${{ matrix.config.SEP }}rd-cpp - artifact: ${{ matrix.config.artifact }}${{ github.run_number }}.zip - name: ${{ matrix.config.name }} - runs-on: ${{ matrix.config.os }} - strategy: - fail-fast: false - matrix: - config: - - { - name: "RD CPP Windows VS 2019", artifact: "RD-CPP-Windows-MSVC-2019-", - os: windows-2019, - cc: "cl", cxx: "cl", - environment_script: "C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/VC/Auxiliary/Build/vcvars64.bat", - SEP: \, - suffix: win-vs19 - } - - { - name: "RD CPP Ubuntu Latest Clang", artifact: "RD-CPP-Linux-Clang-", - os: ubuntu-latest, - cc: "clang", cxx: "clang++", - SEP: /, - suffix: linux-clang - } - - { - name: "RD CPP macOS Latest Clang", artifact: "RD-CPP-macOS-Clang-", - os: macos-latest, - cc: "clang", cxx: "clang++", - SEP: /, - suffix: mac-clang - } - - steps: - - uses: actions/checkout@v1 - - - name: Cache submodules - uses: actions/cache@v2 - id: cache-submodules - with: - path: | - rd-cpp/thirdparty/spdlog - rd-cpp/thirdparty/googletest - key: ${{ matrix.config.os }}-submodules-${{ hashFiles('.gitmodules') }} - - - name: Get submodules - if: steps.cache-submodules.outputs.cache-hit != 'true' - run: git submodule update --init --recursive - - - name: Get nuget - if: steps.cache-nuget.outputs.cache-hit != 'true' - uses: nuget/setup-nuget@v1 - with: - nuget-version: '5.x' - - - name: Cache Ninja - uses: actions/cache@v2 - id: cache-ninja - with: - path: | - rd-cpp/ninja - rd-cpp/ninja.exe - key: ${{ matrix.config.os }}-Ninja-${{ env.NINJA_VERSION }} - - - name: Download Ninja - if: steps.cache-ninja.outputs.cache-hit != 'true' - id: download_ninja - working-directory: ${{ env.working-dir }} - shell: cmake -P {0} - run: | - set(ninja_version $ENV{NINJA_VERSION}) - - message(STATUS "Using host CMake version: ${CMAKE_VERSION}") - - if ("${{ runner.os }}" STREQUAL "Windows") - set(ninja_suffix "win.zip") - elseif ("${{ runner.os }}" STREQUAL "Linux") - set(ninja_suffix "linux.zip") - elseif ("${{ runner.os }}" STREQUAL "macOS") - set(ninja_suffix "mac.zip") - endif() - - set(ninja_url "https://github.com/ninja-build/ninja/releases/download/v${ninja_version}/ninja-${ninja_suffix}") - file(DOWNLOAD "${ninja_url}" ./ninja.zip SHOW_PROGRESS) - execute_process(COMMAND - ${CMAKE_COMMAND} -E tar xvf ./ninja.zip - RESULT_VARIABLE download_ninja_result) - if (NOT download_ninja_result EQUAL 0) - message(FATAL_ERROR "Bad exit status. Fail downloading Ninja") - endif() - - if (NOT "${{ runner.os }}" STREQUAL "Windows") - execute_process(COMMAND chmod +x ninja) - endif() - - - name: Configure - working-directory: ${{ env.working-dir }} - shell: cmake -P {0} - run: | - set(ENV{CC} ${{ matrix.config.cc }}) - set(ENV{CXX} ${{ matrix.config.cxx }}) - file(GLOB all_files "*") - message(${all_files}) - - if ("${{ runner.os }}" STREQUAL "Windows" AND NOT "x${{ matrix.config.environment_script }}" STREQUAL "x") - execute_process( - COMMAND "${{ matrix.config.environment_script }}" && set - OUTPUT_FILE environment_script_output.txt - RESULT_VARIABLE execute_vcvars_result - ) - if (NOT execute_vcvars_result EQUAL 0) - message(FATAL_ERROR "Bad exit status ${execute_vcvars_result}. Fail running ${{ matrix.config.environment_script }}") - endif() - file(STRINGS environment_script_output.txt output_lines) - foreach(line IN LISTS output_lines) - if (line MATCHES "^([a-zA-Z0-9_-]+)=(.*)$") - set(ENV{${CMAKE_MATCH_1}} "${CMAKE_MATCH_2}") - endif() - endforeach() - endif() - - set(path_separator ":") - if ("${{ runner.os }}" STREQUAL "Windows") - set(path_separator ";") - endif() - set(ENV{PATH} "$ENV{GITHUB_WORKSPACE}${path_separator}$ENV{PATH}") - - file(MAKE_DIRECTORY build) - execute_process( - COMMAND ${CMAKE_COMMAND} - -S . - -B build - -DENABLE_TESTS_OPTION:BOOL=OFF - -DCMAKE_BUILD_TYPE=$ENV{BUILD_TYPE} - -G Ninja - -DCMAKE_MAKE_PROGRAM=${CMAKE_CURRENT_SOURCE_DIR}/ninja - RESULT_VARIABLE build_result - ) - if (NOT build_result EQUAL 0) - message(FATAL_ERROR "Bad exit status. Fail building RD CPP") - endif() - - - name: Upload environment script log - uses: actions/upload-artifact@v2 - if: always() - with: - name: build-log-${{ matrix.config.os }} - path: environment_script_output.txt - - - name: Build - working-directory: ${{ env.working-dir }} - shell: cmake -P {0} - run: | - set(ENV{NINJA_STATUS} "[%f/%t %o/sec] ") - file(GLOB all_files "*") - message(${all_files}) - - if ("${{ runner.os }}" STREQUAL "Windows" AND NOT "x${{ matrix.config.environment_script }}" STREQUAL "x") - file(STRINGS environment_script_output.txt output_lines) - foreach(line IN LISTS output_lines) - if (line MATCHES "^([a-zA-Z0-9_-]+)=(.*)$") - set(ENV{${CMAKE_MATCH_1}} "${CMAKE_MATCH_2}") - endif() - endforeach() - endif() - - set(path_separator ":") - if ("${{ runner.os }}" STREQUAL "Windows") - set(path_separator ";") - endif() - set(ENV{PATH} "$ENV{GITHUB_WORKSPACE}${path_separator}$ENV{PATH}") - - execute_process( - COMMAND ${CMAKE_COMMAND} --build build --config ${{ env.BUILD_TYPE }} - RESULT_VARIABLE result - ) - if (NOT result EQUAL 0) - message(FATAL_ERROR "Bad exit status") - endif() - - - name: Install Strip - working-directory: ${{ env.working-dir }} - run: cd build && cmake --config ${{ env.BUILD_TYPE }} -P cmake_install.cmake - - - name: Pack - working-directory: ${{ env.working-dir }} - run: cd export && cmake -E tar "cfv" ../${{ env.artifact }} --format=zip include libs - - - name: Upload - uses: actions/upload-artifact@v2 - with: - path: | - ${{ env.working-dir }}${{ matrix.config.SEP }}export${{ matrix.config.SEP }}** - name: ${{ env.artifact }} diff --git a/.github/workflows/build-rd-kt-container.yml b/.github/workflows/build-rd-kt-container.yml deleted file mode 100644 index 036ec1b82..000000000 --- a/.github/workflows/build-rd-kt-container.yml +++ /dev/null @@ -1,41 +0,0 @@ -name: rd-kt-container - -on: - push: - branches: [ master ] - pull_request: - branches: [ master ] - -jobs: - build: - runs-on: ubuntu-20.04 - container: adoptopenjdk/openjdk11:x86_64-ubuntu-jdk-11.0.11_9 - env: - GRADLE_USER_HOME: ${{ github.workspace }}/.github/gradle - TEAMCITY_VERSION: 1 # temporary; to disable cross tests - timeout-minutes: 25 - steps: - - uses: actions/checkout@v2 - - - name: Gradle Wrapper Cache - uses: actions/cache@v1.1.0 - with: - path: ${{ env.GRADLE_USER_HOME }}/wrapper - key: ${{ runner.os }}.gradle-wrapper.${{ hashFiles('gradle/**') }} -# TODO: See https://github.com/actions/runner/issues/449 -# - name: Gradle Cache -# uses: actions/cache@v1.1.0 -# with: -# path: ${{ env.GRADLE_USER_HOME }}/caches/modules-2 -# key: ${{ runner.os }}.gradle.${{ hashFiles('**/*.gradle.kts') }} - - - name: Assemble - run: ./gradlew assemble - - name: Build - run: ./gradlew build - - name: Upload Test Results - uses: actions/upload-artifact@v2 - if: ${{ always() }} - with: - name: tests-log.${{ runner.os }} - path: "**/reports/*" diff --git a/.github/workflows/build-rd-kt.yml b/.github/workflows/build-rd-kt.yml deleted file mode 100644 index fa6b7d3d3..000000000 --- a/.github/workflows/build-rd-kt.yml +++ /dev/null @@ -1,42 +0,0 @@ -name: rd-kt - -on: - push: - branches: [ master ] - pull_request: - branches: [ master ] - -jobs: - build: - runs-on: ${{ matrix.os }} - strategy: - matrix: - os: [macos-10.15, windows-2019] - env: - GRADLE_USER_HOME: ${{ github.workspace }}/.github/gradle - TEAMCITY_VERSION: 1 # temporary; to disable cross tests - timeout-minutes: 25 - steps: - - uses: actions/checkout@v2 - - - name: Gradle Wrapper Cache - uses: actions/cache@v1.1.0 - with: - path: ${{ env.GRADLE_USER_HOME }}/wrapper - key: ${{ runner.os }}.gradle-wrapper.${{ hashFiles('gradle/**') }} - - name: Gradle Cache - uses: actions/cache@v1.1.0 - with: - path: ${{ env.GRADLE_USER_HOME }}/caches/modules-2 - key: ${{ runner.os }}.gradle.${{ hashFiles('**/*.gradle.kts') }} - - - name: Assemble - run: ./gradlew assemble - - name: Build - run: ./gradlew build - - name: Upload Test Results - uses: actions/upload-artifact@v2.2.4 - if: ${{ always() }} - with: - name: tests-log.${{ runner.os }} - path: "**/reports/*" diff --git a/.github/workflows/build-rd-net.yml b/.github/workflows/build-rd-net.yml deleted file mode 100644 index 28fbc0a7e..000000000 --- a/.github/workflows/build-rd-net.yml +++ /dev/null @@ -1,30 +0,0 @@ -name: rd-net - -on: - push: - branches: [ master ] - pull_request: - branches: [ master ] - -jobs: - build: - runs-on: windows-latest - timeout-minutes: 15 - steps: - - uses: actions/checkout@v2 - - name: Setup .NET Core SDK - uses: actions/setup-dotnet@v1.8.2 - with: - dotnet-version: '6.0.x' - - name: Restore - run: cd rd-net && dotnet restore - - name: Compile - run: cd rd-net && dotnet build --configuration Release --no-restore - - name: Tests - run: cd rd-net && dotnet test --no-restore --verbosity quiet --logger trx - - uses: actions/upload-artifact@v2 - if: failure() - with: - name: tests-log - path: "**/TestResults/*" - diff --git a/.github/workflows/qodana.yml b/.github/workflows/qodana.yml index 74386d29c..fe76b7615 100644 --- a/.github/workflows/qodana.yml +++ b/.github/workflows/qodana.yml @@ -23,9 +23,9 @@ jobs: password: ${{ secrets.SPACE_PASSWORD }} - run: docker pull registry.jetbrains.team/p/sa/containers/qodana-dotnet:231.5593.88.172 - name: 'Qodana Scan' - uses: JetBrains/qodana-action@v5.1.0 + uses: JetBrains/qodana-action@v2022.3.0 with: - args: "--linter,registry.jetbrains.team/p/sa/containers/qodana-dotnet:231.5593.88.172,--changes" + args: "--linter,registry.jetbrains.team/p/sa/containers/qodana-dotnet:231.5593.88.172" - name: 'Deploy to GitHub Pages' uses: peaceiris/actions-gh-pages@v3 with: diff --git a/.github/workflows/release-rd-cpp.yml b/.github/workflows/release-rd-cpp.yml deleted file mode 100644 index d0d59a984..000000000 --- a/.github/workflows/release-rd-cpp.yml +++ /dev/null @@ -1,224 +0,0 @@ -name: release-rd-cpp - -on: - workflow_dispatch: - inputs: - release-version: - description: 'Release version (e.g. 202.1.1)' - required: true - -env: - NINJA_VERSION: 1.9.0 - BUILD_TYPE: Release - -jobs: - build: - env: - working-dir: ${{ github.workspace}}${{ matrix.config.SEP }}rd-cpp - artifact: ${{ matrix.config.artifact }}${{ github.event.inputs.release-version }}.zip - rd-bintray-user: ${{ secrets.RD_BINTRAY_USER }} - rd-bintray-key: ${{ secrets.RD_BINTRAY_KEY }} - name: ${{ matrix.config.name }} - runs-on: ${{ matrix.config.os }} - strategy: - fail-fast: false - matrix: - config: - - { - name: "RD CPP Windows Latest MSVC", artifact: "RD-CPP-Windows-MSVC-2019-", - os: windows-latest, - cc: "cl", cxx: "cl", - environment_script: "C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/VC/Auxiliary/Build/vcvars64.bat", - SEP: \, - suffix: win-vs19 - } - - { - name: "RD CPP Ubuntu Latest Clang", artifact: "RD-CPP-Linux-Clang-", - os: ubuntu-latest, - cc: "clang", cxx: "clang++", - SEP: /, - suffix: linux-clang - } - - { - name: "RD CPP macOS Latest Clang", artifact: "RD-CPP-macOS-Clang-", - os: macos-latest, - cc: "clang", cxx: "clang++", - SEP: /, - suffix: mac-clang - } - - steps: - - uses: actions/checkout@v1 - - - name: Cache submodules - uses: actions/cache@v2 - id: cache-submodules - with: - path: | - rd-cpp/thirdparty/spdlog - rd-cpp/thirdparty/googletest - key: ${{ matrix.config.os }}-submodules-${{ hashFiles('.gitmodules') }} - - - name: Get submodules - if: steps.cache-submodules.outputs.cache-hit != 'true' - run: git submodule update --init --recursive - - - name: Get nuget - if: steps.cache-nuget.outputs.cache-hit != 'true' - uses: nuget/setup-nuget@v1 - with: - nuget-version: '5.x' - - - name: Cache Ninja - uses: actions/cache@v2 - id: cache-ninja - with: - path: | - rd-cpp/ninja - rd-cpp/ninja.exe - key: ${{ matrix.config.os }}-Ninja-${{ env.NINJA_VERSION }} - - - name: Download Ninja - if: steps.cache-ninja.outputs.cache-hit != 'true' - id: download_ninja - working-directory: ${{ env.working-dir }} - shell: cmake -P {0} - run: | - set(ninja_version $ENV{NINJA_VERSION}) - - message(STATUS "Using host CMake version: ${CMAKE_VERSION}") - - if ("${{ runner.os }}" STREQUAL "Windows") - set(ninja_suffix "win.zip") - elseif ("${{ runner.os }}" STREQUAL "Linux") - set(ninja_suffix "linux.zip") - elseif ("${{ runner.os }}" STREQUAL "macOS") - set(ninja_suffix "mac.zip") - endif() - - set(ninja_url "https://github.com/ninja-build/ninja/releases/download/v${ninja_version}/ninja-${ninja_suffix}") - file(DOWNLOAD "${ninja_url}" ./ninja.zip SHOW_PROGRESS) - execute_process(COMMAND - ${CMAKE_COMMAND} -E tar xvf ./ninja.zip - RESULT_VARIABLE download_ninja_result) - if (NOT download_ninja_result EQUAL 0) - message(FATAL_ERROR "Bad exit status. Fail downloading Ninja") - endif() - - if (NOT "${{ runner.os }}" STREQUAL "Windows") - execute_process(COMMAND chmod +x ninja) - endif() - - - name: Configure - working-directory: ${{ env.working-dir }} - shell: cmake -P {0} - run: | - set(ENV{CC} ${{ matrix.config.cc }}) - set(ENV{CXX} ${{ matrix.config.cxx }}) - file(GLOB all_files "*") - message(${all_files}) - - if ("${{ runner.os }}" STREQUAL "Windows" AND NOT "x${{ matrix.config.environment_script }}" STREQUAL "x") - execute_process( - COMMAND "${{ matrix.config.environment_script }}" && set - OUTPUT_FILE environment_script_output.txt - RESULT_VARIABLE execute_vcvars_result - ) - if (NOT execute_vcvars_result EQUAL 0) - message(FATAL_ERROR "Bad exit status. Fail running ${{ matrix.config.environment_script }}") - endif() - file(STRINGS environment_script_output.txt output_lines) - foreach(line IN LISTS output_lines) - if (line MATCHES "^([a-zA-Z0-9_-]+)=(.*)$") - set(ENV{${CMAKE_MATCH_1}} "${CMAKE_MATCH_2}") - endif() - endforeach() - endif() - - set(path_separator ":") - if ("${{ runner.os }}" STREQUAL "Windows") - set(path_separator ";") - endif() - set(ENV{PATH} "$ENV{GITHUB_WORKSPACE}${path_separator}$ENV{PATH}") - - file(MAKE_DIRECTORY build) - execute_process( - COMMAND ${CMAKE_COMMAND} - -S . - -B build - -DENABLE_TESTS_OPTION:BOOL=OFF - -DCMAKE_BUILD_TYPE=$ENV{BUILD_TYPE} - -G Ninja - -DCMAKE_MAKE_PROGRAM=${CMAKE_CURRENT_SOURCE_DIR}/ninja - RESULT_VARIABLE build_result - ) - if (NOT build_result EQUAL 0) - message(FATAL_ERROR "Bad exit status. Fail building RD CPP") - endif() - - - - name: Build - working-directory: ${{ env.working-dir }} - shell: cmake -P {0} - run: | - set(ENV{NINJA_STATUS} "[%f/%t %o/sec] ") - file(GLOB all_files "*") - message(${all_files}) - - if ("${{ runner.os }}" STREQUAL "Windows" AND NOT "x${{ matrix.config.environment_script }}" STREQUAL "x") - file(STRINGS environment_script_output.txt output_lines) - foreach(line IN LISTS output_lines) - if (line MATCHES "^([a-zA-Z0-9_-]+)=(.*)$") - set(ENV{${CMAKE_MATCH_1}} "${CMAKE_MATCH_2}") - endif() - endforeach() - endif() - - set(path_separator ":") - if ("${{ runner.os }}" STREQUAL "Windows") - set(path_separator ";") - endif() - set(ENV{PATH} "$ENV{GITHUB_WORKSPACE}${path_separator}$ENV{PATH}") - - execute_process( - COMMAND ${CMAKE_COMMAND} --build build --config ${{ env.BUILD_TYPE }} - RESULT_VARIABLE result - ) - if (NOT result EQUAL 0) - message(FATAL_ERROR "Bad exit status") - endif() - - - name: Install Strip - working-directory: ${{ env.working-dir }} - run: cd build && cmake --config ${{ env.BUILD_TYPE }} -P cmake_install.cmake - - - name: Pack - working-directory: ${{ env.working-dir }} - run: cd export && cmake -E tar "cfv" ../${{ env.artifact }} --format=zip include libs - - - name: Upload - uses: actions/upload-artifact@v2 - with: - path: | - ${{ env.working-dir }}${{ matrix.config.SEP }}export${{ matrix.config.SEP }}** - name: ${{ env.artifact }} - - - name: Pack Nuget - working-directory: ${{ env.working-dir }}${{ matrix.config.SEP }}export - run: nuget pack rd-cpp.nuspec -Version ${{ github.event.inputs.release-version }} -Suffix ${{ matrix.config.suffix }} - - - name: Add sources - if: ${{ env.rd-bintray-user != '' && env.rd-bintray-key != '' }} - working-directory: ${{ env.working-dir }}${{ matrix.config.SEP }}export - continue-on-error: true - run: nuget sources Add -Name Bintray -Source https://api.bintray.com/nuget/jetbrains/rd-nuget -UserName ${{ env.rd-bintray-user }} -Password ${{ env.rd-bintray-key }} - - - name: Set API key - if: ${{ env.rd-bintray-user != '' && env.rd-bintray-key != '' }} - working-directory: ${{ env.working-dir }}${{ matrix.config.SEP }}export - run: nuget setapikey ${{ env.rd-bintray-user }}:${{ env.rd-bintray-key }} -Source Bintray - - - name: Push nuget - if: ${{ env.rd-bintray-user != '' && env.rd-bintray-key != '' }} - working-directory: ${{ env.working-dir }}${{ matrix.config.SEP }}export - run: nuget push JetBrains.RdFramework.Cpp.${{ github.event.inputs.release-version }}-${{ matrix.config.suffix }}.nupkg -Source https://api.bintray.com/nuget/jetbrains/rd-nuget From c68c6da86d384802b95a79af6225d023d0ad24dc Mon Sep 17 00:00:00 2001 From: Dima Golovinov Date: Mon, 23 Jan 2023 17:23:22 +0100 Subject: [PATCH 04/18] Try to fake the correct behaviour --- .github/workflows/qodana.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/qodana.yml b/.github/workflows/qodana.yml index fe76b7615..26f08be38 100644 --- a/.github/workflows/qodana.yml +++ b/.github/workflows/qodana.yml @@ -25,7 +25,7 @@ jobs: - name: 'Qodana Scan' uses: JetBrains/qodana-action@v2022.3.0 with: - args: "--linter,registry.jetbrains.team/p/sa/containers/qodana-dotnet:231.5593.88.172" + args: "--linter,registry.jetbrains.team/p/sa/containers/qodana-dotnet:231.5593.88.172,--script,local-changes" - name: 'Deploy to GitHub Pages' uses: peaceiris/actions-gh-pages@v3 with: From 1c4c2cd25b53474de6de2792093cd791e69039b6 Mon Sep 17 00:00:00 2001 From: Dima Golovinov Date: Mon, 23 Jan 2023 19:04:05 +0100 Subject: [PATCH 05/18] Add unnecessary file --- rd-net/Lifetimes/Core/NewFile.cs | 9 +++++++++ 1 file changed, 9 insertions(+) create mode 100644 rd-net/Lifetimes/Core/NewFile.cs diff --git a/rd-net/Lifetimes/Core/NewFile.cs b/rd-net/Lifetimes/Core/NewFile.cs new file mode 100644 index 000000000..1d6dbf1ff --- /dev/null +++ b/rd-net/Lifetimes/Core/NewFile.cs @@ -0,0 +1,9 @@ +namespace JetBrains.Core; + +public class NewFile +{ + static void Foo() + { + int a = 42; + } +} \ No newline at end of file From 0976162d53e9954b16529014b5d6d4aa83f70e31 Mon Sep 17 00:00:00 2001 From: Dima Golovinov Date: Tue, 24 Jan 2023 11:14:25 +0100 Subject: [PATCH 06/18] Update version --- .github/workflows/qodana.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/qodana.yml b/.github/workflows/qodana.yml index 26f08be38..739961fba 100644 --- a/.github/workflows/qodana.yml +++ b/.github/workflows/qodana.yml @@ -21,11 +21,11 @@ jobs: registry: registry.jetbrains.team username: Dmitry.Golovinov password: ${{ secrets.SPACE_PASSWORD }} - - run: docker pull registry.jetbrains.team/p/sa/containers/qodana-dotnet:231.5593.88.172 + - run: docker pull registry.jetbrains.team/p/sa/containers/qodana-dotnet:231.5593.152.39 - name: 'Qodana Scan' uses: JetBrains/qodana-action@v2022.3.0 with: - args: "--linter,registry.jetbrains.team/p/sa/containers/qodana-dotnet:231.5593.88.172,--script,local-changes" + args: "--linter,registry.jetbrains.team/p/sa/containers/qodana-dotnet:231.5593.152.39" - name: 'Deploy to GitHub Pages' uses: peaceiris/actions-gh-pages@v3 with: From 0ac7f1ae979146b2f4bee51cdab3e6f777d7859f Mon Sep 17 00:00:00 2001 From: Dima Golovinov Date: Tue, 24 Jan 2023 12:36:39 +0100 Subject: [PATCH 07/18] Push report to the cloud --- .github/workflows/qodana.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/qodana.yml b/.github/workflows/qodana.yml index 739961fba..42b1a57a3 100644 --- a/.github/workflows/qodana.yml +++ b/.github/workflows/qodana.yml @@ -26,6 +26,8 @@ jobs: uses: JetBrains/qodana-action@v2022.3.0 with: args: "--linter,registry.jetbrains.team/p/sa/containers/qodana-dotnet:231.5593.152.39" + env: + QODANA_TOKEN: ${{ secrets.QODANA_TOKEN }} - name: 'Deploy to GitHub Pages' uses: peaceiris/actions-gh-pages@v3 with: From 120f6d137a7434aa4f8bda4fc2704f01d2081612 Mon Sep 17 00:00:00 2001 From: Dima Golovinov Date: Tue, 24 Jan 2023 13:04:37 +0100 Subject: [PATCH 08/18] Try 1 more time --- .github/workflows/qodana.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/qodana.yml b/.github/workflows/qodana.yml index 42b1a57a3..b31ff411d 100644 --- a/.github/workflows/qodana.yml +++ b/.github/workflows/qodana.yml @@ -24,10 +24,10 @@ jobs: - run: docker pull registry.jetbrains.team/p/sa/containers/qodana-dotnet:231.5593.152.39 - name: 'Qodana Scan' uses: JetBrains/qodana-action@v2022.3.0 - with: - args: "--linter,registry.jetbrains.team/p/sa/containers/qodana-dotnet:231.5593.152.39" env: QODANA_TOKEN: ${{ secrets.QODANA_TOKEN }} + with: + args: "--linter,registry.jetbrains.team/p/sa/containers/qodana-dotnet:231.5593.152.39" - name: 'Deploy to GitHub Pages' uses: peaceiris/actions-gh-pages@v3 with: From 43086943bc59f05786b54b242609fb233f554aa4 Mon Sep 17 00:00:00 2001 From: Dima Golovinov Date: Tue, 24 Jan 2023 13:10:40 +0100 Subject: [PATCH 09/18] Remove tabs --- .github/workflows/qodana.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/qodana.yml b/.github/workflows/qodana.yml index b31ff411d..8dd5c6dce 100644 --- a/.github/workflows/qodana.yml +++ b/.github/workflows/qodana.yml @@ -24,8 +24,8 @@ jobs: - run: docker pull registry.jetbrains.team/p/sa/containers/qodana-dotnet:231.5593.152.39 - name: 'Qodana Scan' uses: JetBrains/qodana-action@v2022.3.0 - env: - QODANA_TOKEN: ${{ secrets.QODANA_TOKEN }} + env: + QODANA_TOKEN: ${{ secrets.QODANA_TOKEN }} with: args: "--linter,registry.jetbrains.team/p/sa/containers/qodana-dotnet:231.5593.152.39" - name: 'Deploy to GitHub Pages' From 7d8d18b4b1fbad6a4cbdf8bc5a8b500e7dfc6b6b Mon Sep 17 00:00:00 2001 From: Dima Golovinov Date: Tue, 24 Jan 2023 14:37:53 +0100 Subject: [PATCH 10/18] Add branch info --- .github/workflows/qodana.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/qodana.yml b/.github/workflows/qodana.yml index 8dd5c6dce..4a7580de7 100644 --- a/.github/workflows/qodana.yml +++ b/.github/workflows/qodana.yml @@ -26,6 +26,7 @@ jobs: uses: JetBrains/qodana-action@v2022.3.0 env: QODANA_TOKEN: ${{ secrets.QODANA_TOKEN }} + QODANA_BRANCH: testbranch with: args: "--linter,registry.jetbrains.team/p/sa/containers/qodana-dotnet:231.5593.152.39" - name: 'Deploy to GitHub Pages' From 57355a0bc2d79188cfc25f165f8ef2b53aa221aa Mon Sep 17 00:00:00 2001 From: Dima Golovinov Date: Tue, 24 Jan 2023 14:47:57 +0100 Subject: [PATCH 11/18] Add branch --- .github/workflows/qodana.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/qodana.yml b/.github/workflows/qodana.yml index 4a7580de7..5366ab801 100644 --- a/.github/workflows/qodana.yml +++ b/.github/workflows/qodana.yml @@ -28,7 +28,7 @@ jobs: QODANA_TOKEN: ${{ secrets.QODANA_TOKEN }} QODANA_BRANCH: testbranch with: - args: "--linter,registry.jetbrains.team/p/sa/containers/qodana-dotnet:231.5593.152.39" + args: "--linter,registry.jetbrains.team/p/sa/containers/qodana-dotnet:231.5593.152.39,-e,QODANA_BRANCH=testbranch" - name: 'Deploy to GitHub Pages' uses: peaceiris/actions-gh-pages@v3 with: From 2edc4806bd98a0ee99defc1b2540d9a3ad9d97e4 Mon Sep 17 00:00:00 2001 From: Dima Golovinov Date: Tue, 24 Jan 2023 15:55:29 +0100 Subject: [PATCH 12/18] one more try --- .github/workflows/qodana.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/qodana.yml b/.github/workflows/qodana.yml index 5366ab801..0363f355a 100644 --- a/.github/workflows/qodana.yml +++ b/.github/workflows/qodana.yml @@ -26,9 +26,11 @@ jobs: uses: JetBrains/qodana-action@v2022.3.0 env: QODANA_TOKEN: ${{ secrets.QODANA_TOKEN }} - QODANA_BRANCH: testbranch + QODANA_REMOTE_URL: https://github.com/${{ github.repository }} + QODANA_BRANCH: ${{ github.head_ref }} + QODANA_JOB_URL: https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }} with: - args: "--linter,registry.jetbrains.team/p/sa/containers/qodana-dotnet:231.5593.152.39,-e,QODANA_BRANCH=testbranch" + args: "--linter,registry.jetbrains.team/p/sa/containers/qodana-dotnet:231.5593.152.39" - name: 'Deploy to GitHub Pages' uses: peaceiris/actions-gh-pages@v3 with: From d02ff698f5530db01552883b88ad1a81c69b72d5 Mon Sep 17 00:00:00 2001 From: Dima Golovinov Date: Tue, 24 Jan 2023 18:36:19 +0100 Subject: [PATCH 13/18] New action --- .github/workflows/qodana.yml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/.github/workflows/qodana.yml b/.github/workflows/qodana.yml index 0363f355a..bfbde5906 100644 --- a/.github/workflows/qodana.yml +++ b/.github/workflows/qodana.yml @@ -23,12 +23,9 @@ jobs: password: ${{ secrets.SPACE_PASSWORD }} - run: docker pull registry.jetbrains.team/p/sa/containers/qodana-dotnet:231.5593.152.39 - name: 'Qodana Scan' - uses: JetBrains/qodana-action@v2022.3.0 + uses: JetBrains/qodana-action@tiulpin/2232 env: QODANA_TOKEN: ${{ secrets.QODANA_TOKEN }} - QODANA_REMOTE_URL: https://github.com/${{ github.repository }} - QODANA_BRANCH: ${{ github.head_ref }} - QODANA_JOB_URL: https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }} with: args: "--linter,registry.jetbrains.team/p/sa/containers/qodana-dotnet:231.5593.152.39" - name: 'Deploy to GitHub Pages' From 1141d963119e6f593a37ab21a3dc5e878e45ff5c Mon Sep 17 00:00:00 2001 From: Dima Golovinov Date: Wed, 8 Feb 2023 10:32:37 +0100 Subject: [PATCH 14/18] Clean up yaml --- .github/workflows/qodana.yml | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/.github/workflows/qodana.yml b/.github/workflows/qodana.yml index bfbde5906..6ecf94f2b 100644 --- a/.github/workflows/qodana.yml +++ b/.github/workflows/qodana.yml @@ -15,19 +15,10 @@ jobs: - uses: actions/checkout@v3 with: fetch-depth: 0 - - name: Login to Jetbrains Space - uses: docker/login-action@v2 - with: - registry: registry.jetbrains.team - username: Dmitry.Golovinov - password: ${{ secrets.SPACE_PASSWORD }} - - run: docker pull registry.jetbrains.team/p/sa/containers/qodana-dotnet:231.5593.152.39 - name: 'Qodana Scan' - uses: JetBrains/qodana-action@tiulpin/2232 + uses: JetBrains/qodana-action@v2022.3.2 env: QODANA_TOKEN: ${{ secrets.QODANA_TOKEN }} - with: - args: "--linter,registry.jetbrains.team/p/sa/containers/qodana-dotnet:231.5593.152.39" - name: 'Deploy to GitHub Pages' uses: peaceiris/actions-gh-pages@v3 with: From 16cefc4c6fd286bfd59ec0ae804e77f7356f2ff0 Mon Sep 17 00:00:00 2001 From: Dima Golovinov Date: Wed, 8 Feb 2023 10:53:50 +0100 Subject: [PATCH 15/18] Rollback action version --- .github/workflows/qodana.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/qodana.yml b/.github/workflows/qodana.yml index 6ecf94f2b..24d9488b2 100644 --- a/.github/workflows/qodana.yml +++ b/.github/workflows/qodana.yml @@ -16,7 +16,7 @@ jobs: with: fetch-depth: 0 - name: 'Qodana Scan' - uses: JetBrains/qodana-action@v2022.3.2 + uses: JetBrains/qodana-action@tiulpin/2232 env: QODANA_TOKEN: ${{ secrets.QODANA_TOKEN }} - name: 'Deploy to GitHub Pages' From 771ccaf1e1e369aa9a32adbd745f90a84921a596 Mon Sep 17 00:00:00 2001 From: Dima Golovinov Date: Wed, 8 Feb 2023 12:58:19 +0100 Subject: [PATCH 16/18] Fix --- .github/workflows/qodana.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/qodana.yml b/.github/workflows/qodana.yml index 24d9488b2..84cf01e8b 100644 --- a/.github/workflows/qodana.yml +++ b/.github/workflows/qodana.yml @@ -16,7 +16,7 @@ jobs: with: fetch-depth: 0 - name: 'Qodana Scan' - uses: JetBrains/qodana-action@tiulpin/2232 + uses: JetBrains/qodana-action@v2022.3.3 env: QODANA_TOKEN: ${{ secrets.QODANA_TOKEN }} - name: 'Deploy to GitHub Pages' From a0e6b0b615c893539ecb8e5948cb731ff76265fd Mon Sep 17 00:00:00 2001 From: hybloid <48032702+hybloid@users.noreply.github.com> Date: Wed, 22 Feb 2023 15:25:15 +0100 Subject: [PATCH 17/18] Test changing data --- rd-net/Scripts/LineEndingUtil.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/rd-net/Scripts/LineEndingUtil.cs b/rd-net/Scripts/LineEndingUtil.cs index 57ecaf6ff..5abc0afbb 100644 --- a/rd-net/Scripts/LineEndingUtil.cs +++ b/rd-net/Scripts/LineEndingUtil.cs @@ -10,6 +10,7 @@ public static string Detect(string path) using (var fileStream = File.OpenRead(path)) { char prevChar = '\0'; + char foo = prevChar; for (int i = 0; i < 4000; i++) { int b; From efedf0a178669952a18e0e83b93a12ebb2881098 Mon Sep 17 00:00:00 2001 From: Dima Golovinov Date: Mon, 8 May 2023 11:57:28 +0200 Subject: [PATCH 18/18] Update GitHub action version --- .github/workflows/qodana.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/qodana.yml b/.github/workflows/qodana.yml index 84cf01e8b..926016783 100644 --- a/.github/workflows/qodana.yml +++ b/.github/workflows/qodana.yml @@ -16,7 +16,7 @@ jobs: with: fetch-depth: 0 - name: 'Qodana Scan' - uses: JetBrains/qodana-action@v2022.3.3 + uses: JetBrains/qodana-action@v2023.1.0 env: QODANA_TOKEN: ${{ secrets.QODANA_TOKEN }} - name: 'Deploy to GitHub Pages'