8000 [columnar] Don't use vectorized aggregates if FILTER is used by mkaruza · Pull Request #181 · hydradatabase/columnar · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[columnar] Don't use vectorized aggregates if FILTER is used #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2023
Merged

[columnar] Don't use vectorized aggregates if FILTER is used #181

merged 1 commit into from
Oct 25, 2023

Conversation

mkaruza
Copy link
Contributor
@mkaruza mkaruza commented Oct 25, 2023
  • Don't use vectorized aggregates if FILTER is used. FILTER is part of aggregate node execution - not part of custom scan.

@mkaruza mkaruza requested a review from wuputah October 25, 2023 06:25
@mkaruza
[columnar] Don't use vectorized aggregates if FILTER is used
215372f
8000 
* Don't use vectorized aggregates if FILTER is used. FILTER is part of
  aggregate node execution - not part of custom scan.
@wuputah wuputah requested a review from JerrySievert October 25, 2023 17:05
wuputah
wuputah approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member
@wuputah wuputah left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naively, it looks weird because you would think elog(ERROR, …) would not alter the flow control, but it does.

If the severity level is ERROR or higher, ereport aborts execution of the current query and does not return to the caller. If the severity level is lower than ERROR, ereport returns normally.

Thanks for the tests! ✅

JerrySievert
JerrySievert approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor
@JerrySievert JerrySievert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mkaruza mkaruza merged commit 45b5f95 into main Oct 25, 2023
@mkaruza mkaruza deleted the github#180 branch October 25, 2023 18:28
@wuputah wuputah mentioned this pull request Oct 27, 2023
Closed
@wuputah wuputah mentioned this pull request Nov 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wuputah wuputah wuputah approved these changes

@JerrySievert JerrySievert JerrySievert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkaruza @wuputah @JerrySievert
0