8000 Import references should not be able to reference the import target by dsa0x · Pull Request #36801 · hashicorp/terraform · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Import references should not be able to reference the import target #36801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account rel 8000 ated emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 1, 2025
Merged

Import references should not be able to reference the import target #36801

merged 3 commits into from
Apr 1, 2025

Conversation

dsa0x
Copy link
Member
@dsa0x dsa0x commented Mar 31, 2025 •
edited
Loading

This disables the import block from being able to reference anywhere else the resource in its "to" attribute, as that will lead to a cyclic dependency.

Fixes #36672

Target Release

1.12.x

CHANGELOG entry

  • This change is user-facing and I added a changelog entry.
  • This change is not user-facing.

@dsa0x dsa0x force-pushed the sams/import-self-ref branch from 3f11d1b to 9829f4f Compare March 31, 2025 13:12
@dsa0x dsa0x marked this pull request as ready for review March 31, 2025 13:29
@dsa0x dsa0x requested a review from a team as a code owner March 31, 2025 13:29
jbardin
jbardin reviewed Mar 31, 2025
View reviewed changes
@dsa0x dsa0x force-pushed the sams/import-self-ref branch from 7600af5 to 29351bb Compare March 31, 2025 16:26
@dsa0x dsa0x requested a review from jbardin March 31, 2025 17:01
jbardin
jbardin previously approved these changes Mar 31, 2025
View reviewed changes
@jbardin
Copy link
Member
jbardin commented Mar 31, 2025

FYI your Fixes# is pointing back at this PR

jbardin
jbardin reviewed Mar 31, 2025
View reviewed changes
.changes/v1.12/BUG FIXES-20250331-150802.yaml Outdated
body: for_each expressions in import blocks should not be able to reference the import target
time: 2025-03-31T15:08:02.156881+02:00
custom:
Issue: "36672"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should point to the PR, not the issue

dsa0x
dsa0x commented Apr 1, 2025
View reviewed changes
@dsa0x dsa0x merged commit d6e1d26 into main Apr 1, 2025
8 checks passed
@dsa0x dsa0x deleted the sams/import-self-ref branch April 1, 2025 07:19
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented May 2, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jbardin jbardin jbardin left review comments

@liamcervante liamcervante liamcervante approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

import for_each should not be able to reference the import target
3 participants
@dsa0x @jbardin @liamcervante
0