8000 Store test screenshots for ui tests by dbanck · Pull Request #1906 · hashicorp/vscode-terraform · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Store test screenshots for ui tests #1906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 9, 2024
Merged

Store test screenshots for ui tests #1906

merged 2 commits into from
Dec 9, 2024

Conversation

dbanck
Copy link
Member
@dbanck dbanck commented Dec 9, 2024 •
edited
Loading

This PR allows us to store screenshots for failed UI tests. We'll only create the artefact when a test fails and store it for one day.

Example: https://github.com/hashicorp/vscode-terraform/actions/runs/12234779622/job/34124676411?pr=1906#step:11:23

@dbanck dbanck force-pushed the c-store-test-screenshots branch 4 times, most recently from a810766 to 40407cc Compare December 9, 2024 11:34
@dbanck dbanck marked this pull request as ready for review December 9, 2024 11:35
@dbanck dbanck requested a review from a team as a code owner December 9, 2024 11:35
jpogran
jpogran approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor
@jpogran jpogran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@dbanck dbanck force-pushed the c-store-test-screenshots branch from 40407cc to 3b948e0 Compare December 9, 2024 14:02
@dbanck dbanck merged commit 1154b9b into main Dec 9, 2024
13 checks passed
@dbanck dbanck deleted the c-store-test-screenshots branch December 9, 2024 14:07
@github-actions GitHub Actions
Copy link
github-actions bot commented Jan 9, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jpogran jpogran jpogran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbanck @jpogran
0