8000 Heap allocation weirdnesses · Issue #5 · hashlookup/fleur · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Heap allocation weirdnesses #5
Closed
@gallypette

Description

@gallypette
  • allocate only once,
  • no static

The usage of static variables makes the BloomFilter code unnecessarily dangerous to use when multiple threads are used even if every thread just wants to allocate and use totally separate bloom filters. Actually it could even cause issues with two bloom filters created after each other since even Initialize just returns a pointer to a single static BloomFilter :o I can't come up with a reason why you'd consider making anything in there static.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    0