8000 Tado component fails to add climate components when Hot Water is present · Issue #9530 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Tado component fails to add climate components when Hot Water is present #9530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
beanian opened this issue Sep 21, 2017 · 6 comments · Fixed by #10927
Closed

Tado component fails to add climate components when Hot Water is present #9530

beanian opened this issue Sep 21, 2017 · 6 comments · Fixed by #10927

Comments

@beanian
Copy link
beanian commented Sep 21, 2017

Home Assistant release (hass --version):
0.53.1

Component/platform:
Tado

Description of problem:
Error creating the climate components when Hot Water is part of your tado system

Expected:
climate components get created for each zone

Traceback (if applicable):

2017-09-21 21:15:04 DEBUG (SyncWorker_13) [PyTado.interface] api call: GET: zones/0/capabilities, response <http.client.HTTPResponse object at 0x7ff40542f588>
2017-09-21 21:15:04 ERROR (MainThread) [homeassistant.components.climate] Error while setting up platform tado
Traceback (most recent call last):
  File "/usr/src/app/homeassistant/helpers/entity_component.py", line 164, in _async_setup_platform
    SLOW_SETUP_MAX_WAIT, loop=self.hass.loop)
  File "/usr/local/lib/python3.6/asyncio/tasks.py", line 358, in wait_for
    return fut.result()
  File "/usr/local/lib/python3.6/asyncio/futures.py", line 245, in result
    raise self._exception
  File "/usr/local/lib/python3.6/concurrent/futures/thread.py", line 55, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/src/app/homeassistant/components/climate/tado.py", line 60, in setup_platform
    tado, hass, zone, zone['name'], zone['id']))
  File "/usr/src/app/homeassistant/components/climate/tado.py", line 76, in create_climate_device
    temperatures = capabilities['temperatures']

Additional info:
I opened the my.tado.com site and had a look at the json result from the GET request to /zone/0:

{"type":"HOT_WATER","canSetTemperature":false}

As you can see it is for hot water and doesnt contain a temperatures array like the code is expecting
@amirandap
Copy link
amirandap commented Oct 29, 2017 •
edited
Loading

Mine also fails but i dont have any hot water

2017-10-29 12:30:28 ERROR (MainThread) [homeassistant.components.climate] Error while setting up platform tado
Traceback (most recent call last):
  
  File "/srv/homeassistant/lib/python3.5/site-packages/homeassistant/helpers/entity_component.py", line 170, in _async_setup_platform
    SLOW_SETUP_MAX_WAIT, loop=self.hass.loop)
  
  File "/usr/lib/python3.5/asyncio/tasks.py", line 400, in wait_for
    return fut.result()
 
  File "/usr/lib/python3.5/asyncio/futures.py", line 293, in result
    raise self._exception
  
  File "/usr/lib/python3.5/concurrent/futures/thread.py", line 55, in run
    result = self.fn(*self.args, **self.kwargs)
  
  File "/srv/homeassistant/lib/python3.5/site-packages/homeassistant/components/climate/tado.py", line 60, in setup_platform
    tado, hass, zone, zone['name'], zone['id']))
  
  File "/srv/homeassistant/lib/python3.5/site-packages/homeassistant/components/climate/tado.py", line 74, in create_climate_device
    temperatures = capabilities['HEAT']['temperatures']
KeyError: 'HEAT'

@michaelarnauts
Copy link
Contributor

Is this still an issue in 0.58.1? I've setup my tado without an issue and it created a climate.heating and a climate.hot_water.

On the my.tado.com page, I have a Heating and a Hot water configuration.

@dasos
Copy link
Contributor
dasos commented Nov 29, 2017

Yes, it is an issue for me in 58.1. @wmalgadey , are you maintaining this? Otherwise I might submit a PR. I think for now, a simple check to exclude the device if type = HOT_WATER. Longer term, we may want a different device type. The challenge is that hot water can only be turned on or off. No other data is provided. Thoughts?

@dasos
Copy link
Contributor
dasos commented Nov 29, 2017

@michaelarnauts - can you control the temperature of the hot water in app?

@wmalgadey
Copy link
Contributor

Hi dasos,

I am quite busy in the moment. So, if you could make a PR this would be awesome!

@dasos dasos mentioned this issue Dec 3, 2017
Merged
@dasos
Copy link
Contributor
dasos commented Dec 4, 2017

Done in #10927

@home-assistant home-assistant locked and limited conversation to collaborators Mar 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tado ignore invalid devices
5 participants
@wmalgadey @beanian @michaelarnauts @dasos @amirandap
0