From 7a39ae40c569b7a72b9abe08c3a8ff4791756125 Mon Sep 17 00:00:00 2001 From: Patrik Date: Sun, 5 Nov 2017 10:23:53 +0100 Subject: [PATCH 1/3] Fix problem with brightness --- homeassistant/components/light/tradfri.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/homeassistant/components/light/tradfri.py b/homeassistant/components/light/tradfri.py index 0a54522d7b7282..4aa16448b21b45 100644 --- a/homeassistant/components/light/tradfri.py +++ b/homeassistant/components/light/tradfri.py @@ -108,6 +108,9 @@ def async_turn_on(self, **kwargs): keys['transition_time'] = int(kwargs[ATTR_TRANSITION]) * 10 if ATTR_BRIGHTNESS in kwargs: + if ATTR_BRIGHTNESS == 255: + ATTR_BRIGHTNESS = 254 + self.hass.async_add_job(self._api( self._group.set_dimmer(kwargs[ATTR_BRIGHTNESS], **keys))) else: @@ -260,6 +263,9 @@ def async_turn_on(self, **kwargs): keys['transition_time'] = int(kwargs[ATTR_TRANSITION]) * 10 if ATTR_BRIGHTNESS in kwargs: + if ATTR_BRIGHTNESS == 255: + ATTR_BRIGHTNESS = 254 + self.hass.async_add_job(self._api( self._light_control.set_dimmer(kwargs[ATTR_BRIGHTNESS], **keys))) From c61dd5ba4a7ff7e92ecb7312b599ce68b13c5b57 Mon Sep 17 00:00:00 2001 From: Patrik Date: Sun, 5 Nov 2017 10:50:00 +0100 Subject: [PATCH 2/3] Fix typo --- homeassistant/components/light/tradfri.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/homeassistant/components/light/tradfri.py b/homeassistant/components/light/tradfri.py index 4aa16448b21b45..432b76165eec91 100644 --- a/homeassistant/components/light/tradfri.py +++ b/homeassistant/components/light/tradfri.py @@ -108,7 +108,7 @@ def async_turn_on(self, **kwargs): keys['transition_time'] = int(kwargs[ATTR_TRANSITION]) * 10 if ATTR_BRIGHTNESS in kwargs: - if ATTR_BRIGHTNESS == 255: + if kwargs[ATTR_BRIGHTNESS] == 255: ATTR_BRIGHTNESS = 254 self.hass.async_add_job(self._api( @@ -263,7 +263,7 @@ def async_turn_on(self, **kwargs): keys['transition_time'] = int(kwargs[ATTR_TRANSITION]) * 10 if ATTR_BRIGHTNESS in kwargs: - if ATTR_BRIGHTNESS == 255: + if kwargs[ATTR_BRIGHTNESS] == 255: ATTR_BRIGHTNESS = 254 self.hass.async_add_job(self._api( From e778ec9acf029b8367b037a51b8c5bfca8041326 Mon Sep 17 00:00:00 2001 From: Patrik Date: Sun, 5 Nov 2017 10:52:47 +0100 Subject: [PATCH 3/3] Typo --- homeassistant/components/light/tradfri.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/homeassistant/components/light/tradfri.py b/homeassistant/components/light/tradfri.py index 432b76165eec91..a516348c79f06c 100644 --- a/homeassistant/components/light/tradfri.py +++ b/homeassistant/components/light/tradfri.py @@ -109,7 +109,7 @@ def async_turn_on(self, **kwargs): if ATTR_BRIGHTNESS in kwargs: if kwargs[ATTR_BRIGHTNESS] == 255: - ATTR_BRIGHTNESS = 254 + kwargs[ATTR_BRIGHTNESS] = 254 self.hass.async_add_job(self._api( self._group.set_dimmer(kwargs[ATTR_BRIGHTNESS], **keys))) @@ -264,7 +264,7 @@ def async_turn_on(self, **kwargs): if ATTR_BRIGHTNESS in kwargs: if kwargs[ATTR_BRIGHTNESS] == 255: - ATTR_BRIGHTNESS = 254 + kwargs[ATTR_BRIGHTNESS] = 254 self.hass.async_add_job(self._api( self._light_control.set_dimmer(kwargs[ATTR_BRIGHTNESS],