Upgrade netdisco to 1.0.0rc2 #7008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@balloob, thanks for your PR! By analyzing the history of the files in this pull request, we identified @florianholzapfel, @trisk and @robbiet480 to be potential reviewers. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Netdisco 1.0.0 has an updated return value. Instead of tuples it is now all dictionaries. This will give us easy upgrade path and backwards compatibility. Also as added bonus the new netdisco standardizes a lot of data values.
This means that I had to update everywhere where the value from discovery was used.
Checklist:
If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass