skip xinput trigger threshold check #18407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Huh, yeah, indeed forgot to remove this old deadzone handling when centralizing. Should also just get rid of the function NormalizedDeadzoneDiffers, but I'll sneak that into the merge. |
2 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #18404 , remove the hard coded 30.0f/255.0f deadzone on triggers
It should be fine since analog deadzone was moved to control mapper around 633a6f6
To further address #16643 with analog mapped to digital, I'm guessing KeyMap thresholds should be evaluated (if that still happens), but this should already make it harder for analog triggers mapped to digital buttons to get stuck
ppsspp/Core/KeyMap.h
Lines 81 to 83 in 2036f1c