10000 Remove numbers.ParseList sorting side effect · Issue #2011 · ignite/cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove numbers.ParseList sorting side effect #2011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ivanovpetr opened this issue Jan 24, 2022 · 0 comments · Fixed by #2031
Closed

Remove numbers.ParseList sorting side effect #2011

ivanovpetr opened this issue Jan 24, 2022 · 0 comments · Fixed by #2031
Assignees
@ivanovpetr
Labels
component:network type:request Feature request.
Milestone
T1

Comments

@ivanovpetr
Copy link
Contributor
ivanovpetr commented Jan 24, 2022 •
edited
Loading

Package tendermint/starport/starport/pkg/numbers has function ParseList which is used for parsing list of numbers provided as a string. It sorts numbers as a side effect. It could lead to unexpected behaviour as package clients my rely on order of provided number list.

numbers.ParseList should not sort its argument and should have deterministic way of preserving list' order.
@ivanovpetr ivanovpetr added the type:request Feature request. label Jan 24, 2022
@ivanovpetr ivanovpetr self-assigned this Jan 24, 2022
@ilgooz ilgooz added this to the Next milestone Jan 25, 2022
@ivanovpetr ivanovpetr modified the milestones: Next, Network Jan 26, 2022
@ivanovpetr ivanovpetr linked a pull request Jan 27, 2022 that will close this issue
feat(network/request): don't sort and rm support for reverse ordering ranges #2031
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivanovpetr ivanovpetr

Labels
component:network type:request Feature request.
Projects
None yet
Milestone
T1
Development

Successfully merging a pull request may close this issue.

feat(network/request): don't sort and rm support for reverse ordering ranges ignite/cli
2 participants
@ilgooz @ivanovpetr
0