Closed
Description
System and IINA version:
- macOS 13.3.1
- IINA develop 869eaaf
Expected behavior:
IINA shuts down cleanly
Actual behavior:
IINA crashes calling mpv_destroy.
This is a regression in the develop branch reported by @yuxiqian. Big thank you to @yuxiqian noticing and reporting this regression.
Crash report:
Thread 1 Crashed:: Dispatch queue: com.colliderli.iina.controller
0 libsystem_kernel.dylib 0x1a6de0724 __pthread_kill + 8
1 libsystem_pthread.dylib 0x1a6e17c28 pthread_kill + 288
2 libsystem_c.dylib 0x1a6d25ae8 abort + 180
3 libmpv.1.dylib 0x1025ee2ac mp_clients_destroy.cold.1 + 32
4 libmpv.1.dylib 0x10256b030 mp_clients_destroy + 84
5 libmpv.1.dylib 0x10258a09c mp_destroy + 80
6 libmpv.1.dylib 0x10256bba0 mp_destroy_client + 940
7 IINA 0x101140b00 MPVController.handleEvent(_:) + 1820 (MPVController.swift:830)
8 IINA 0x101140188 closure #1 in MPVController.readEvents() + 544 (MPVController.swift:783)
9 IINA 0x100ce1d9c thunk for @escaping @callee_guaranteed () -> () + 48
10 libdispatch.dylib 0x1a6c66874 _dispatch_call_block_and_release + 32
11 libdispatch.dylib 0x1a6c68400 _dispatch_client_callout + 20
12 libdispatch.dylib 0x1a6c6fa88 _dispatch_lane_serial_drain + 668
13 libdispatch.dylib 0x1a6c705f8 _dispatch_lane_invoke + 384
14 libdispatch.dylib 0x1a6c7b244 _dispatch_workloop_worker_thread + 648
15 libsystem_pthread.dylib 0x1a6e14074 _pthread_wqthread + 288
16 libsystem_pthread.dylib 0x1a6e12d94 start_wqthread + 8
Steps to reproduce:
With a build of the current develop branch:
-
Confirm the
At launchsetting is set toShow welcome window -
Start IINA
-
Wait for the welcome window to appear
-
Click
Quit IINAunder theIINAmenu -
IINA crashes
-
MPV does not have this problem.
How often does this happen?
Every time.