8000 Adding an interval parameter in ROIUtils.bresenham() · Issue #27 · imglib/imglib2-roi · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Adding an interval parameter in ROIUtils.bresenham() #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hadim opened this issue Apr 29, 2016 · 5 comments
Open

Adding an interval parameter in ROIUtils.bresenham() #27

hadim opened this issue Apr 29, 2016 · 5 comments

Comments

@hadim
Copy link
hadim commented Apr 29, 2016

That would be nice to have an interval parameter such as in Line.getInterpolatedPolygon() (https://github.com/imagej/ImageJA/blob/master/src/main/java/ij/gui/Roi.java#L439) in ROIUtils.bresenham().
@hadim hadim mentioned this issue Apr 29, 2016
Open
@hadim
Copy link
Author
hadim commented Apr 29, 2016 •
edited
Loading

For now ROIUtils.bresenham() does not return a number of points that correspond to the rounded euclidean distance of p1 and p2 in ROIUtils.bresenham({p1, p2}) while it's the case with Line.getInterpolatedPolygon(interval=1).

@hadim
Copy link
Author
hadim commented May 9, 2016

Any toughs @tpietzsch ?

@hadim hadim closed this as completed Dec 17, 2016
@ctrueden
Copy link
Member

@hadim When you close an issue, can you please include a note why?

@hadim
Copy link
Author
hadim commented Dec 18, 2016

Sorry. I was reviewing old issues and because I didn't find any more activities beside me here I thought it would be best to just close it.

I guess I was tired when I did that. I'll just re open it.

@hadim hadim reopened this Dec 18, 2016
@imagejan
Copy link
Member
imagejan commented Oct 7, 2022

Note that meanwhile, with a9cebea, the bresenham() method moved to GeomMaths:

imglib2-roi/src/main/java/net/imglib2/roi/geom/GeomMaths.java

Lines 256 to 260 in 46e8890

// TODO: bresenham(vertices) assumes closed loop of vertices (first vertex
// is repeated after last vertex). It would be useful to have a version that
// doesn't assume that, and a version that just takes 2 points.
public static List< Localizable > bresenham( final List< ? extends RealLocalizable > vertices )
{

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hadim @ctrueden @imagejan
0