-
Notifications
You must be signed in to change notification settings - Fork 189
Incompatible with React Native 0.79.0 and Expo 53.0.0 - axios
dependency
#331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Related: #329 |
axios
dependency
Probably just need to upgrade axios. Will look into this shortly. |
Sounds good, let me know if you need anything! |
I tried upgrading axios manually but I am still getting this error. |
@ChristopherGabba Is the issue only when building against the NA? |
@robinheinze if by NA you mean New Architecture (I had to ask gpt lol), I have not tried bumping to 0.79.0 and Expo 53 on old architecture yet. It is for sure present on the new architecture, but I can test on old tomorrow and get back to you. |
Haha, sorry 😅 Based on some digging I think it's affecting both.. It's an axios breaking change introduced in 1.8.0. There's currently a PR that is open but not merged. axios/axios#6802. Seems like for now the best solution is to pin the Axios version to 1.7.9 #329 (comment) |
Once that PR is merged, we'll update the dependencies to the new version. |
So have some more info on this I think.
resolver: {
extraNodeModules: require('@pagopa/react-native-nodelibs'),
}, which adds a lot of polyfills but I still cannot get it to work since its impossible to polyfill all without an error in the polyfill itself. So why does 1. and 2. work and why does 3. require lots of polyfills? |
@andidev That's great info. I'll dig in a bit more to see why that might be. |
There is also a new related issue filed on Axios axios/axios#6899 |
Thanks guys for looking into this. This is the last hurdle for me to get to expo 53, so hopefully someone with axios gets a handle on it... |
Here's another workaround from a metro issue facebook/metro#1272 (comment). As soon as there's a stable fix in Axios we'll release a new version. |
@robinheinze Hi, axios has fixed the problem in 1.8.1, could you please to release a new version? Our project is blocked by this problem. Thanks. |
@foresthuo 1.8.1 has been out for a while and other folks in this thread have said in this thread it doesn't solve the issue. @vishva-simform is on 1.9.0 for example and is still facing it. There are workarounds that others have said successfully unblocked them if you read through the comments here axios/axios#6899 (comment) |
I tried upgrading my app to the latest and greatest just to do a dependency test on the new architecture and
apisauce
blocked the build, no matter what I messed with. I triedyarn
s resolutions, etc and it never would compile.It seems to be related to dependencies of axios -
crypto
,url
, etc. and not being compatible with node.The text was updated successfully, but these errors were encountered: