8000 Add an auction functionality to the escrow module · Issue #133 · iov-one/starnamed · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add an auction functionality to the escrow module #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
LeCodeurDuDimanche opened this issue Oct 27, 2021 · 2 comments · May be fixed by #150
Open

Add an auction functionality to the escrow module #133

LeCodeurDuDimanche opened this issue Oct 27, 2021 · 2 comments · May be fixed by #150
Assignees
@LeCodeurDuDimanche
Labels
v0.11.x

Comments

@LeCodeurDuDimanche
Copy link
Contributor

Add auction functionality to the existing escrow module
@LeCodeurDuDimanche LeCodeurDuDimanche self-assigned this Oct 27, 2021
@LeCodeurDuDimanche
Copy link
Contributor Author
LeCodeurDuDimanche commented Oct 27, 2021 •
edited
Loading
  • Implement the data types and basic verification
  • Determine the behavior of an auction when it is expired (automatic completion ?)
  • Should we allow modifying the seller of an auction after it was created ?
  • Give a specific fee for creating an auction
  • Give a specific fee for bids (notably for the broker commission)
  • Can a bidder add other tokens to the price ?
  • Update the keeper's methods
  • Add isAuction field as secondary key for searching/filtering data
  • Do the auction completion logic
  • Update the CLI/REST interfaces
  • Add tests and update invariants

@LeCodeurDuDimanche LeCodeurDuDimanche linked a pull request Nov 28, 2021 that will close this issue
Draft
@LeCodeurDuDimanche
Copy link
Contributor Author
LeCodeurDuDimanche commented Nov 28, 2021 •
edited
Loading
  • Add the gRPC Service to complete an auction

@LeCodeurDuDimanche LeCodeurDuDimanche mentioned this issue Dec 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LeCodeurDuDimanche LeCodeurDuDimanche

Labels
v0.11.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add auctions to the escrow module iov-one/starnamed
2 participants
@davepuchyr @LeCodeurDuDimanche
0