8000 Wait command not waiting properly · Issue #1550 · irssi/irssi · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Wait command not waiting properly #1550
Open
@trinitronx

Description

@trinitronx

Using irssi version 1.5+1.dev.r237.g5c159375 5c15937, the /wait command appears to not work anymore. In the 1.4.5 version, this worked properly to close automatically opened windows (e.g. NickServ, SaslServ, etc...)

chatnets = {
  testserver = {
    type = "IRC";
    nick = "exampleuser";
    username = "exampleuser";
    realname = "exampleuser";
    autosendcmd = "/echo begin autosendcmd--; /waitwinclose 10000 SaslServ; /waitwinclose 10000 NickServ; /echo end autosendcmd--";
  };
};

aliases = {
  WAITWINCLOSE = "/echo wait $0; /wait $0; /echo /unquery $1; /unquery $1;";
  ALTWAITWINCLOSE = "/echo wait $0; /wait $0; /echo /window goto $1; /wc;";
};

Result:

22:21:56 -!- begin autosendcmd--
22:21:56 -!- wait 10000
22:21:56 -!- /unquery SaslServ
22:21:56 [testserver] -!- Irssi: No query with SaslServ
22:21:56 -!- wait 10000
22:21:56 -!- /unquery NickServ
22:21:56 [testserver] -!- Irssi: No query with NickServ
22:21:56 -!- end autosendcmd--

Seems to be a regression in the irssi 1.5 development version. According to the log, the commands are all run within the same second without waiting.

EDIT: After checking the source code and seeing this if condition, I wondered if maybe server was NULL. To test this, I decided to try passing the optional server parameter to /wait using the following:

chatnets = {
  testserver = {
    type = "IRC";
    nick = "exampleuser";
    username = "exampleuser";
    realname = "exampleuser";
    autosendcmd = "/echo begin autosendcmd--; /waitwinclose -testserver 3000 SaslServ; /waitwinclose -testserver 2000 NickServ; /echo end autosendcmd--";
  };
};

aliases = {
  WAITWINCLOSE = "/echo wait $0 $1; /wait $0 $1; /echo /unquery $2; /unquery $2;";
};

However, this still didn't work and had the same result as before. The wait did not appear to work, and the SaslServ and NickServ windows remained open.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0