8000 Refactor duplicative, opaque run_hook scripts · Issue #1140 · jupyter/docker-stacks · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Refactor duplicative, opaque run_hook scripts #1140
Closed
@parente

Description

@parente

Follow-on work from #1132 ...

We wrote a set of bash scripts for Docker Hub to update the project wiki with build metadata. We stuck with bash, sed, and heredocs as we found use of Python and other languages unreliable in the Docker Hub build environment.

Now that we're running builds on GitHub Actions, we should make the entire post-build hook process more contributor friendly using Python. We can replace most if not all of the docker commands in the heredoc templates with calls using the Python docker client, which is already in the dev requirements for this project. We can also reduce code duplication by having a singular post build script and reasonable markdown templates for populating image specific values.

Metadata

Metadata

Assignees

No one assigned

    Labels

    type:MaintenanceA proposed enhancement to how we maintain this project

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0