8000 Window error include path · Issue #1 · jakobwesthoff/phuml · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on May 28, 2021. It is now read-only.

Window error include path #1

Open
akulubala opened this issue Mar 12, 2014 · 3 comments
Open

Window error include path #1

akulubala opened this issue Mar 12, 2014 · 3 comments

Comments

@akulubala
Copy link

Hi In windows there have a little error under sr/config/config.php line 7.

ini_set(
    'include_path',
    ini_get( "include_path" ) . ':' . BASEDIR
);

should be like this:

if (strtoupper(substr(PHP_OS, 0, 3)) === 'WIN') {
      $colon= ";";
 );
}else{
     $colon= ":";
 }
ini_set(
    'include_path',
    ini_get( "include_path" ) . $colon. BASEDIR
  );
@jakobwesthoff
Copy link
Owner

What should actually be used here is the PATH_SEPARATOR constant instead of the hard coded colon or the os detection logic. As I am not really maintaining this project any more I won't fix this by myself. PRs on the other hand are very welcome und will gladly be merged!

@akulubala
Copy link
Author

@jakobwesthoff ..thanks a lot.

@dialogik
Copy link
Contributor

Have a look at PR #3.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jakobwesthoff @dialogik @akulubala
0