8000 Comparing jruby:master...janx:master · jruby/jruby · GitHub

More Web Proxy on the site http://driver.im/

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.

...

fix the "Builder::XmlMarkup#to_ary should return Array" problem caused by 1.9 proc call #73

I first got this error in a rails 3.1 app running on jruby 1.6.4 (1.9 mode): Failure/Error: format.xml do render :xml => @foo, :status => :ok end TypeError: Builder::XmlMarkup#to_ar

View pull request

1 commit
1 file changed
1 contributor

Commits on Sep 8, 2011

5F03

skip to_ary if it yields non-array result in 1.9 proc call:

* How to reproduce:

    require 'rubygems'
    require 'builder'

    b = Builder::XmlMarkup.new
    p = proc { puts 1 }
    p.call b

Above code will raise exception on jruby 1.9, pass on MRI 1.9.

* Cause:

Classes like Builder::XmlMarkup changes common methods like to_ary
to return different type result, so it's not safe to expect to_ary
always return a ruby Array.

Jan Xie committed Sep 8, 2011

0