Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 4 commits
- 15 files changed
- 1 contributor
Commits on Nov 15, 2024
-
Upgrade emscripten build (#282)
Currently failing due to nodejs dependencies: Setting up EMSDK environment (suppress these messages with EMSDK_QUIET=1) Adding directories to PATH: PATH += /__w/libcoro/libcoro/emsdk PATH += /__w/libcoro/libcoro/emsdk/upstream/emscripten PATH += /__w/libcoro/libcoro/emsdk/node/20.18.0_64bit/bin Setting environment variables: PATH = /__w/libcoro/libcoro/emsdk:/__w/libcoro/libcoro/emsdk/upstream/emscripten:/__w/libcoro/libcoro/emsdk/node/20.18.0_64bit/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin EMSDK = /__w/libcoro/libcoro/emsdk EMSDK_NODE = /__w/libcoro/libcoro/emsdk/node/20.18.0_64bit/bin/node node: bad option: --experimental-wasm-eh
-
Add test for when_all throwing on individual tasks. (#281)
The original behavior for coro::when_all was to capture the T result or an exception and then when the user iterates all of the completed tasks the task.return_value() would either return the result or re-throw the exception for that specific task.
Commits on Jan 29, 2025
-
I don't have a mac to test on and I've been unable to get the CI jobs to work.. debugging the github actions isn't straightforward. These jobs will be disabled until someone can provide a working CI job script. Closes #289
Commits on Jan 30, 2025
-
coro::task_container gc fix not completing coroutines (#288)
* coro::task_container gc fix not completing coroutines The coro::task_container::gc_internal function was deleting coroutines when marked as .done(), however there is some mechanism that rarely would cause the user_task coroutine to not actually execute. I'm still not sure exactly why this is the case but: 1) Simply disabling gc_internal() would stop the problem 2) Running gc_internal() and moving the coro::task to a 'dead' list still caused the issue. With these in mind I spent time re-reading the specification on the final_suspend and determined that coro::task_container should be a thing atomic counter to track the submitted coroutines and have them self delete. The self deletion is now done via a coro::detail::task_self_destroying coroutine type that takes advantage of the promise's final_suspend() not suspending. The spec states that if this doesn't suspend then the coroutine will call destroy() on itself. Closes #287
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v0.12.1...v0.13.0