8000 A better way to disable Sparkle · Issue #4 · jbtule/NicePlayer · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

A better way to di 8ABC sable Sparkle #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ryandesign opened this issue Oct 17, 2018 · 0 comments
Open

A better way to disable Sparkle #4

ryandesign opened this issue Oct 17, 2018 · 0 comments

Comments

@ryandesign
Copy link

Hi, I'm a developer with the MacPorts project, trying to update our NicePlayer port to the latest version. It's been a long time since we updated this port, and now that I'm trying to do so, I'm running into many problems, so apologies for filing so many bug reports all at once, but I figured you'd want to know.

Some support for disabling Sparkle was added in f8446d3, but it has a number of problems:

  1. It requires the user to edit the Xcode project and add -D__MACPORTS__ to Other C Flags.
  2. If the user chooses the Check For Updates menu item, a message is displayed that says the program was installed using MacPorts.
  3. The Sparkle framework is still built and installed.

1 and 2 are weird if the program is not in fact being built by MacPorts—for example, if it is being built by Homebrew or Fink or just by a user who wants to disable Sparkle support. 3 is bad because it wastes time building something that is not needed or wanted, and that can in itself lead to problems—in my case, the Sparkle framework fails to build because it uses openssl headers which are no longer part of macOS. So in order to get this to build in MacPorts, I had to add a dependency on the MacPorts openssl port, and edit the Sparkle Xcode project to add the path to the MacPorts openssl headers and libraries, all so that I could build a Sparkle framework that I didn't want to have.

So it would be great if there were a better way to disable all Sparkle functionality in NicePlayer—a way that does not reference MacPorts, and that results in no parts of Sparkle being built or installed. I am not certain what the best way is within Xcode to offer such options, but maybe a separate configuration or a separate target is the answer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ryandesign
0