8000 Sample lua custom writer fixes (mostly editorial) · Issue #7487 · jgm/pandoc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Sample lua custom writer fixes (mostly editorial) #7487
Closed
@wlupton

Description

@wlupton

Here are some comments on the v2.14.1 sample lua custom writer. Please let me know if I should create separate issues for any of them.

  1. Attribute sorting: attributes(attr) uses pairs(attr), which I believe means that the attribute order is unpredictable (not a problem per se, but annoying if ever comparing the output from multiple runs). Probably it should do whatever the Haskell HTML writer does?

  2. Link attributes: Link(s, tgt, tit, attr) ignores the attr argument.

  3. Image versus figure: CaptionedImage(src, tit, caption, attr) doesn't check for empty captions. I'm not sure about this one: I did hit it in real life, but it's possible that it was caused by a lua filter fiddling with the caption.

  4. Unintentional head global? Table(caption, aligns, widths, headers, rows) can update a global head variable that doesn't appear to be declared or used anywhere. Probably it can just be removed?

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0